Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add types for urqlCacheKeys #20027

Merged
merged 2 commits into from
Feb 3, 2022
Merged

feat: add types for urqlCacheKeys #20027

merged 2 commits into from
Feb 3, 2022

Conversation

estrada9166
Copy link
Member

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 2, 2022

Thanks for taking the time to open a PR!

@estrada9166 estrada9166 requested a review from tgriesser February 2, 2022 22:20
@cypress
Copy link

cypress bot commented Feb 2, 2022 •
edited
Loading


Test summary

17925 • 0 • 211 • 0 • Flakiness 4

Run details
Project cypress
Status Passed
Commit 054d78d
Started Feb 3, 2022 6:31 PM
Ended Feb 3, 2022 6:44 PM
Duration 13:10 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

commands/net_stubbing.cy.ts 2 Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout incrementally waiting on requests
commands/navigation.cy.js 1 Flakiness
1 src/cy/commands/navigation > #visit > window immediately resolves and doesn't reload when visiting the same URL with hashes
cypress/proxy-logging.cy.ts 1 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@estrada9166 estrada9166 merged commit 321ebd7 into 10.0-release Feb 3, 2022
@estrada9166 estrada9166 deleted the alejandro/feat/add-types-for-urqlCacheKeys branch February 3, 2022 19:33
tgriesser added a commit that referenced this pull request Feb 4, 2022
@tgriesser
Merge branch '10.0-release' into tgriesser/refactor/error-improvements
dd5e8e3 
* 10.0-release:
  feat: validate specPattern root level (#19980)
  feat(unify): unsupported browsers (#19997)
  feat: persist isSideNavigationOpen (#20026)
  feat: add types for urqlCacheKeys (#20027)
  fix: rename spec.js to spec.cy.js (#20029)
  feat: waiting for dependencies to be installed in wizard (#19955)
  fix: migrate config fields to correct the location (#19940)
  feat: relaunch browser when switching testing types from app (#19961)
  test: final ct-audit tests and component tweaks (#19948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgriesser tgriesser tgriesser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estrada9166 @tgriesser