-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: throw when writing to 'read only' properties of config
#18896
Merged
davidmunechika
merged 88 commits into
develop
from
issue-6407-warn-for-read-only-properties
Dec 10, 2021
+314
−17
Merged
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
65b3dd7
add readonly prop
davidmunechika 2e26506
remove read only
davidmunechika 8177afc
verify config options
davidmunechika 531059c
format
davidmunechika 8c157e6
fix verify merge conflicts
davidmunechika 36269a0
add retries property
davidmunechika 65e91ae
add new properties
davidmunechika b91e503
fix config override test
davidmunechika 464254e
update writeable options
davidmunechika f9beb27
fix testConfigList
davidmunechika 53a9665
fix request spec test
davidmunechika 380cda8
refactor validate into config package
davidmunechika 7b27835
fix isInteractive default
davidmunechika b71fd60
add config options
davidmunechika 0b35210
fix keystroke validation
davidmunechika 3088a52
update snapshot
davidmunechika 0296226
fix public config key snapshot
davidmunechika 6014e5d
add unit tests
davidmunechika 235b5b9
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
davidmunechika e8dee2d
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
davidmunechika 75a4b09
testConfigList check
davidmunechika 7e9743e
Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi…
davidmunechika 404247d
fix test config overrides for .only
davidmunechika 19e9bed
add tests
davidmunechika 3f4063e
add test config override tests
davidmunechika 6c26a27
fix config override test
davidmunechika ecf1fee
refactor error message
davidmunechika c37cd33
fix unit tests
davidmunechika 0e7fb85
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
davidmunechika 45b726d
remove .only
davidmunechika 982b320
Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi…
davidmunechika 6e625c4
fix fixtures spec message
davidmunechika d6568ee
fix error handling
davidmunechika ab97136
fix unit test
davidmunechika 25fbe7a
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
davidmunechika 2e74c1d
add description for isWriteable
davidmunechika 69175b8
Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi…
davidmunechika d3b8898
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
davidmunechika 120fd49
remove .been
davidmunechika d3df4b8
Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi…
davidmunechika e49178f
remove read-only properties
davidmunechika f6332f4
remove exit property
davidmunechika b24a0f1
skip validation for internal use
davidmunechika e7ea235
update public config keys
davidmunechika 7c350d7
fix config spec
davidmunechika e3986a6
add env check to config override test
davidmunechika a56364a
convert array to object
davidmunechika a4e004a
runtime config options not writeable
davidmunechika 0c8360e
move error messages to errUtils
davidmunechika ef210c8
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
davidmunechika 52e5cfb
remove isInteractive public option
davidmunechika 019a4a3
update snapshots
davidmunechika f644e25
update naming
davidmunechika 7d80bbc
update index naming
davidmunechika 9a9ff67
update types
davidmunechika 905feef
fix config spec
davidmunechika edd66e4
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
davidmunechika 46ed7ec
restore snapshots
davidmunechika cecc6a4
Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi…
davidmunechika 6738f3e
make isInteractive internal
davidmunechika 138298d
add runtime config option types
davidmunechika a4626f5
fix type failure
davidmunechika b80340e
add cypress internal env to system test
davidmunechika b4f7194
remove internal from isInteractive
davidmunechika a9ab97a
update types
davidmunechika a7ea29d
only verify cypress config
davidmunechika fedae31
pass cypress internal env in system test
davidmunechika 1ddc0a0
move how env is passed in system tests
davidmunechika 4a121fa
use processEnv with error ui spec
davidmunechika bcfca89
use createIndex
davidmunechika 590eb0e
fix logic for test config override options
davidmunechika 33d4db0
fix logic for test config override options
davidmunechika 2d9efd5
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
emilyrohrbough 0c9c8dd
only check read only properties
davidmunechika d20a59e
Merge branch 'issue-6407-warn-for-read-only-properties' of https://gi…
davidmunechika 101d445
add unit tests for non-cypress config
davidmunechika 875e287
use window.top instead of env
davidmunechika 3165ac0
fix runner tests
davidmunechika 6c8ea25
update system tests
davidmunechika 24ff38f
update error ui specs
davidmunechika 8a65255
update snapshot text
davidmunechika b4fd2ae
fix error ui spec
davidmunechika 4f790a1
add ts-ignore
davidmunechika 0c3b26e
fix line numbers for system tests
davidmunechika 31955ad
update snapshot
davidmunechika 54e7548
update unit tests
davidmunechika abfabc0
fix snapshot spacing
davidmunechika de7b436
Merge branch 'develop' into issue-6407-warn-for-read-only-properties
davidmunechika File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add unit tests
commit 6014e5dae71cb253b0cf1ec22b721ad540e7ab92
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also assert that the argument passed to the error function is the expected option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're at it,
expect(errorFn).to.have.callCount(0)
orexpect(errorFn).not.to.have.beenCalled
😬There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be updated!