fix: support using create-cypress-tests as part of build process #18714
Conversation
lmiller1990
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
lmiller1990
requested review from
a team and
tgriesser
and removed request for
a team and
jennifer-shehane
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -73,7 +73,7 @@ const checkZipSize = function (zipPath) { | |||
| const zipSize = filesize(stats.size, { round: 0 }) | |||
|
|
|||
| console.log(`zip file size ${zipSize}`) | |||
| const MAX_ALLOWED_SIZE_MB = os.platform() === 'win32' ? 295 : 260 | |||
| const MAX_ALLOWED_SIZE_MB = os.platform() === 'win32' ? 295 : 300 | |||
There was a problem hiding this comment.
Can decrease when we remove all the old code, prior to merging this feature branch?
There was a problem hiding this comment.
Saw this last week and was looking to fix before we merged #18704. One last thing needed - we need to ensure that create-cypress-tests is copied over to the binary builds, which it currently isn't because it doesn't start with @cypress/.
It's a simple fix in this code, but was looking to get failing tests for it before I pushed, since this isn't seeming to catch that because of how the node_modules resolves, thinking we need to rm -rf packages && rm -rf npm or something after the build, before we run the smoke tests. Will push that up in a few.
| "create-cypress-tests": "0.0.0-development", | ||
| "cross-fetch": "^3.1.4", | ||
| "dataloader": "^2.0.0", | ||
| "dedent": "^0.7.0", | ||
| "electron": "14.1.0", |
There was a problem hiding this comment.
Must've missed when this happened. I don't think we should be depending on electron, if anything it should be injected from server.
There was a problem hiding this comment.
Yeah I agree, I thought it was a bit weird a data layer pulls in electron - we should remove that. I think @ImCesar is working around electron now, maybe he can remove the reference to electron we have in data-context when he is back.
|
I added |
…ve-activeProject * unified-desktop-gui: (57 commits) chore: Add e2e tests for global mode (#18719) chore: add percy to app and launchpad package (#18781) chore: update test refactor: move settings in app (#18729) feat: setup launchpad lifecycle (#18734) feat(app): decouple event manager from driver (#18695) chore: Force single resolution for core modules, infinite loop guard (#18764) fix(driver): Sticky elements within a fixed container will not prevent an element from being scrolled to (#18441) chore: cleaning up the runner container pattern (#18741) feat: Use .config files (#18578) chore(app): basic style and example to stop scrollIntoView bug (#18736) chore: make `create` function on server.ts obsolete (#18615) feat: add codegen utility (#18708) docs: Add instructions to squash commits to develop in Contributing (#18728) fix(@cypress/react): throw if using Next.js swc-loader without nodeVersion=system (#18686) refactor: remove Ramda (#18723) fix: support using create-cypress-tests as part of build process (#18714) chore: Increase paralleled machines for desktop-gui tests (#18725) fix(app): do not cache graphql (#18716) chore: Update Chrome (stable) to 95.0.4638.69 (#18696) ...
create-cypress-testsinside ofpackagesdata-contextExample failing step: https://app.circleci.com/pipelines/github/cypress-io/cypress/25799/workflows/adc8b63e-591b-4aa6-a4e5-119ccf9f2708/jobs/969136