feat(app): persist current spec in data context, update runner workflow for demo #18406
Conversation
|
Thanks for taking the time to open a PR!
|
lmiller1990
requested review from
chrisbreiding and
BlueWinds
and removed request for
a team,
chrisbreiding and
BlueWinds
| @@ -9,32 +9,41 @@ | |||
| <div>{{ t('specPage.componentSpecsHeader') }}</div> | |||
| <div>{{ t('specPage.gitStatusHeader') }}</div> | |||
| </div> | |||
| <router-link | |||
There was a problem hiding this comment.
For now just using gql as the source of truth, not sure if there's a specific reason we need to keep the current spec in the URL or not 🤔
| // TODO: Do we need this many ways to describe a spec? | ||
|
|
||
| // represents a spec file on file system and | ||
| export interface BaseSpec { |
There was a problem hiding this comment.
Many parts of the system (mainly server) assume a "spec" is exactly
absolute:
relative:
name:
and nothing else. Our definitions of a "spec" are getting kinda messy, we need to unify these eventually.
| @@ -426,6 +426,11 @@ export const eventManager = { | |||
| }) | |||
|
|
|||
| Cypress.on('log:added', (log) => { | |||
| // TODO: Race condition in unified runner - we should not need this null check | |||
There was a problem hiding this comment.
Do we know anything about the cause of this race condition / any potential impact?
There was a problem hiding this comment.
I looked and it seems like Cypress is trying to log GraphQL requests as the AUT is unmounted (eg, if you click to return to the Spec page, it makes a GraphQL request).
I think I need to ensure the driver has fully stopped and been torn down.
There was a problem hiding this comment.
I will be pairing with Brian this week on this.
@lmiller1990 The tests aren't flaky, they weren't passing in #18372 due to the change in the history routing We need to hold off merging until the required status checks are passing given then number of folks that are now working off of this branch across teams. |
* unified-desktop-gui: feat(app): persist current spec in data context, update runner workflow for demo (#18406)
Did:
currentSpecfield toactiveProject/runnerroute and run specI am not sure why but the
appcomponent tests are flaky - seems like a Vite issue. The launchpad CT tests seem fine, though. You can test it like this:cd packages/launchpadyarn dev/__vite__/in the Cypress browserKnown issues (to solve in other PRs, to avoid this getting huge):
cy.viewportfails. This is going to be fixed as part of the iframes ticketDemo!
demook.mov