-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(driver): cy.pause()
should not be ignored with cypress run --headed --no-exit
#18358
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…cypress-io/cypress into issue-4044-pause-ignored-headed
…cypress-io/cypress into issue-4044-pause-ignored-headed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeowch, this is a hard PR to test all the way...
Since you are not creating a full e2e test for this fix, only an integration test that uses mocks, i think it would probably be prudent to update a unit/integration test somewhere that also checks that exit
is being passed to the runner
controller, along with isHeadless
, etc. Surely such a test exists already and can be updated to add exit
.
Past that small testing concern, this looks great!
…ramework * unified-desktop-gui: fix conflicts fix conflicts feat: create a copy when selecting a pre-existing story (#18440) feat: add configured state to TestingTypeCard (#18461) feat(app): run e2e tests (#18448) fix: frontend-shared typo on windi config feat: make the select language component (#18443) chore: Update Chrome (stable) to 94.0.4606.81 (#18411) release 8.6.0 fix: do not attempt to trim objects when printing to console (#18341) fix(driver): `cy.pause()` should not be ignored with `cypress run --headed --no-exit` (#18358) chore: release @cypress/vite-dev-server-v2.1.1 chore: release @cypress/react-v5.10.1
Is this PR is 9.5.2 ? I downgraded to 8.6.0 and it worked but with the 9.5.2 it is not. Is it a regression ? |
@totomaze - This was released in 9.6.0, and is not in 9.5.2. #4044 (comment) |
The last version where it s working is 9.1.1, after this version using --headed --no-exit no longer pause during a test run. I believe it s caused by this update in 9.2.0: Is there any workaround to get the test to pause when running it by cypress run ? |
pause()
should not be ignored withcypress run --headed --no-exit
#4044User facing changelog
Users will be able to use
cy.pause()
and observe that a test paused when usingcypress run --headed --no-exit
.Additional details
Previous behavior:
cy.pause()
was ignored when usingcypress run
even if--headed
and--no-exit
flags were passed.New behavior:
cy.pause()
works as expected (i.e. the same as withcypress open
) when--headed
and--no-exit
flags are passed tocypress run
.PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
? --> N/A