fix: make vite re-run on supportFile change #17485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lmiller1990
approved these changes
Jul 26, 2021
tgriesser
added a commit
that referenced
this pull request
Aug 2, 2021
…ui/add-context-code-review * unified-desktop-gui: feat: Structuring context & schema so it can be used on the client (#17489) fix: vue 3 types, beta suffix & component name (#17508) fix: last test skipped with top navigation and already run suite (#17498) chore: Update Chrome (beta) to 93.0.4577.18 (#17536) fix: use process.geteuid and catch uid errors in file util (#17488) build: make vite build strict (#17509) release 8.1.0 fix(server): correctly include projectRoot when adding a CI project from GUI (#17514) fix(types): update cy.shadow docs url (#17506) chore(npm/webpack-preprocessor): fix CI pipeline (#17515) fix: test runner reporter performance (#17243) chore: release @cypress/vue-v3.0.0-beta.4 chore: release @cypress/vite-dev-server-v2.0.3 fix: make vite re-run on supportFile change (#17485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Previously, when we changed a spec file, or any of it's dependencies, the current spec would re-run. But the
supportFile, though impactful in the runs, would not be watched.Now Cypress watches the
supportFilefor changes and re-runs the current spec if it changes.Additional details
To reproduce:
yarn workspace @cypress/vite-dev-server cy:openhello-with-jsxtestnpm/vite-dev-server/support.jssee the css file imported in it.npm/vite-dev-server/styles.csshotpinkand saveThe tests are not re-run before this PR
They are after the PR