-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launchpad): launch project and runner with graphql #17460
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…90/launcher-with-gql
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…990/launcher-with-gql
…990/launcher-with-gql
lmiller1990
requested review from
flotwig and
kuceb
and removed request for
a team,
flotwig and
kuceb
July 23, 2021 06:55
Will revisit this in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR builds on the GraphQL layer, adding queries and mutations to do things like:
TODO: tests - I will write many tests once I get a review and make sure the architecture and design is heading the right direction.
TODO: Integrate with UI using Apollo - I will do it in another PR to keep the PRs small.
I need a very thorough review, since I am sure I'm not using GraphQL to it's fullest potential. Some general questions, mainly for @tgriesser
Browser
, which is defined incypress.d.ts
as well as here using Nexus'objectType
. Should we be making Nexus definitions the one and only source of truth now?Here is a demo, showing how I can launch the CT runner using the GraphQL layer. Hooking it up to the UI with Apollo should be straight forward.
Demo:
demo_tr.mov
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?