-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove extra renovate.json file #16385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
jennifer-shehane
requested review from
a team,
flotwig and
kuceb
and removed request for
a team
May 6, 2021 21:40
jennifer-shehane
changed the title
chore: Clean up renovate
chore: Remove extra renovate.json file
May 6, 2021
flotwig
approved these changes
May 6, 2021
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
tgriesser
added a commit
that referenced
this pull request
May 7, 2021
* develop: chore: Remove extra renovate.json file (#16385) Do not print 'uploading' stdout when --quiet mode is passed (#16271) fix(deps): update dependency color-string to version 1.5.5 🌟 (#16362) fix(deps): update dependency cypress-real-events to version 1.4.0 🌟 (#16363) tests: use the proper keys for selecting framework fix: Prevent Firefox from opening custom search when pressing / (#16372) fix: vueCli and webpack key vue@2 fix when guessing tests: update snapshots fix: add return config for vueCli and vueWebpack fix: add return config for vitejs templates chore: release @cypress/vue-v2.2.2 chore: release @cypress/react-v5.5.0 fix: remove all of rollup, not supported anymore fix: typo in the final message (run vs run-ct)
tgriesser
added a commit
that referenced
this pull request
May 7, 2021
* develop: (28 commits) fix: XHR event listener AUT redirect bug (#15995) chore: fix typo (#16345) chore(design-system): Added missing exports and index.ts (#16351) chore: Remove extra renovate.json file (#16385) Do not print 'uploading' stdout when --quiet mode is passed (#16271) fix(deps): update dependency color-string to version 1.5.5 🌟 (#16362) fix(deps): update dependency cypress-real-events to version 1.4.0 🌟 (#16363) tests: use the proper keys for selecting framework fix: Prevent Firefox from opening custom search when pressing / (#16372) fix(socket): update serialization for circular binary socket messages (#16311) fix: vueCli and webpack key vue@2 fix when guessing tests: update snapshots fix: add return config for vueCli and vueWebpack chore(deps): update dependency classnames to version 2.3.1 🌟 (#8337) fix: add return config for vitejs templates chore: release @cypress/vue-v2.2.2 chore: release @cypress/react-v5.5.0 fix: remove all of rollup, not supported anymore fix: typo in the final message (run vs run-ct) fix: use close event when asking the browser for its version (#16312) ...
agg23
added a commit
that referenced
this pull request
May 7, 2021
fix(deps): update dependency cypress-real-events to version 1.4.0 🌟 (#16363) Co-authored-by: Renovate Bot <[email protected]> fix: typo in the final message (run vs run-ct) fix: remove all of rollup, not supported anymore fix: add return config for vitejs templates fix: add return config for vueCli and vueWebpack tests: update snapshots fix: vueCli and webpack key vue@2 fix when guessing tests: use the proper keys for selecting framework chore: release @cypress/react-v5.5.0 [skip ci] chore: release @cypress/vue-v2.2.2 [skip ci] fix(deps): update dependency color-string to version 1.5.5 🌟 (#16362) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]> Do not print 'uploading' stdout when --quiet mode is passed (#16271) chore: Remove extra renovate.json file (#16385) chore(design-system): Added missing exports and index.ts (#16351) chore: fix typo (#16345) Co-authored-by: Jennifer Shehane <[email protected]> fix: XHR event listener AUT redirect bug (#15995) Fixes incorrect redirect when location.href is set to a relative path within the call stack of an XHR event handler, which set the user's AUT to /__/ rather than the correct path Linting after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renovate issue was showing some warning about config.
I found there was an extra
renovate.json
file in one of the npm repos, so maybe this is why this error is displaying. There shouldn’t be 2 renovate.json files regardless.Also removed the packageRules for grouping types deps. In reality, grouping packages just means we never update them because it’s too large of a change on its own.