Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to change browser state #26763

Closed
astone123 opened this issue May 16, 2023 · 2 comments · Fixed by #26884
Closed

Add logic to change browser state #26763

astone123 opened this issue May 16, 2023 · 2 comments · Fixed by #26884
Assignees
@dkasper-was-taken

Comments

@astone123
Copy link
Contributor

astone123 commented May 16, 2023 •
edited by mike-plummer
Loading

In order to switch to the debug page for a specific run when the user clicks a notification, we need to be able to do two things programmatically:

  • Switch the current URL to the debug page
  • Switch the currently selected run on the debug page to the one that the notification was for

Add ways to make this happen in the data-context layer.

Note: A path for this already exists specifically for switching between specs - this can likely be copied & adjusted as needed. See packages/server/lib/makeDataContext.ts: projectApi.runSpec & the function it calls. This is being added/updated in #26782
@astone123 astone123 changed the title Add mutation to change browser state Add logic to change browser state May 16, 2023
@astone123
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @jordanpowell88 @lmiller1990 @marktnoonan @mike-plummer @warrensplayer @dkasper-was-taken

dkasper-was-taken added a commit that referenced this issue May 30, 2023
@dkasper-was-taken
chore: add browser state action for debug (#26763)
b5c8b15
@dkasper-was-taken dkasper-was-taken mentioned this issue May 30, 2023
Merged
1 task
dkasper-was-taken added a commit that referenced this issue Jun 2, 2023
@dkasper-was-taken
chore: add browser state action for debug (#26884)
9c4d5f7 
* chore: add browser state action for debug (#26763)

* Address PR comments
- remove unneeded async and test context
- genericize openProject function

* Revert route change, update spec description
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 7, 2023

Released in 12.14.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.14.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dkasper-was-taken dkasper-was-taken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add browser state action for debug (#26763) cypress-io/cypress
2 participants
@astone123 @dkasper-was-taken