-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CT onboarding hangs waiting for dependency installation #26685
Comments
Your screenshot in #26685 (comment) shows Cypress |
My bad @MikeMcC399 it caught my global Cypress install, confirmed. Thanks again, routing to the team. |
Confirmed it appears to have been introduced in 12.8.0. |
Noticed that refreshing the page seems to work, so this is an issue related to state not syncing correctly with GQL, not the "detecting" logic itself. A similar issue was noticed before and addressed in #26437. I wonder if we need a similar Subscription added to https://github.com/cypress-io/cypress/blob/develop/packages/launchpad/src/setup/InstallDependencies.vue. Loom showing the problem and how refreshing fixes it: |
I fixed it in #26726
I wasn't able to reproduce this - I refreshed the page, but the dependency was not updated. I found it was related to a caching issue. I wonder if there is another unrelated issue. |
Confirmed still an issue with Cypress None of the following changed the condition:
Looking forward now to seeing the rollout of |
Yep, it'll be broken in 12.12.0 too - the fix will be in the next release, just need a few reviews on #26726 . This should be in 2 weeks, unless we do a patch release earlier. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Current behavior
When dependencies have been installed during CT onboarding, the Cypress App continues to wait showing a spinner with the text "Waiting for you to install the dependencies...". It does not exit this condition and requires the Cypress App to be restarted to continue. After restart, the Front-end framework is detected and onboarding continues successfully.
Desired behavior
Onboarding should automatically and dynamically check dependency installation as it did up until Cypress 12.7.0.
After choosing a front-end framework during CT onboarding, for instance
Next.js
, the Cypress App displays a command, such asnpm install -D next react react-dom
, together with a spinner with the text "Waiting for you to install the dependencies...".Now if the command to install packages is executed in a separate terminal window, the spinner and text disappear. The message displaying the command to execute disappears and is replaced with a text saying "You've successfully installed all required dependencies"
Test code to reproduce
Select Component Testing
Select Next.js, click Next step
In a separate terminal window copy and paste
npm install -D next react react-dom
The Cypress App waits showing a spinner with the text "Waiting for you to install the dependencies...". This does not change even when the dependencies have been installed.
Cypress Version
12.11.0
(and12.12.0
)Node version
18.16.0
Operating System
Ubuntu
22.04
(also reproducible on Windows11
)Debug Logs
`cypress:scaffold-config:frameworks` is not detecting the dependencies
Other
Workaround
Kill then restart the Cypress App after installing dev dependencies.
The text was updated successfully, but these errors were encountered: