-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hovering on the video doesn't play the video. Clicking on the video opens a new tab #14757
Comments
|
@bahmutov 2. Manually it doesn't open a second tab. It remains on the same page. |
Try the experimental source rewriting. It probably has to do with the app being inside the iframe
…Sent from my iPhone
On Jan 27, 2021, at 13:43, sinthujan24 ***@***.***> wrote:
@bahmutov 2. Manually it doesn't open a second tab. It remains on the same page.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@bahmutov I tried it. it still opens a new tab. |
I kindly ask you to reopen this issue:
|
So I created reproduction in https://github.com/cypress-io/cypress-test-tiny/tree/opens-new-tab In the normal browser I see a click event handler attached to those video cards In Cypress the same element does not have an event handler. The site has bunch of errors while loading. If you can eliminate everything from the page to find out how the event listener is attached in the browser and why it is not attached inside Cypress, I would be happy to reopen the issue. But without this investigation by someone who understands the implementation of those video cards, I don't think it is productive to investigate. |
@bahmutov I'm seeing element has an event handler and it's click. Image attached |
Yes. And Unfortunately, hover and clicking on the video tile to open the player are the most critical part of our testing. That's why I've been struggling for a solution for last couple of days. Please reopen this issue if the above evidences earns an investigation on cypress side at the least |
Can you extract the minimal reproducible example from this site?
…Sent from my iPhone
On Jan 27, 2021, at 15:51, sinthujan24 ***@***.***> wrote:
Very weird
…
Sent from my iPhone
On Jan 27, 2021, at 15:37, sinthujan24 @.***> wrote: @bahmutov I'm seeing element has an event handler and it's click. Image attached — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
Yes. And Unfortunately, hover and clicking on the video tile to open the player are the most critical part of our testing. That's why I've been struggling for a solution for last couple of days. Please reopen this issue if the above evidences earns an investigation on cypress side at the least
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@bahmutov The code snippets mentioned in #14757 (comment) are the minimal reproducible steps. Did you want me to commit this to https://github.com/cypress-io/cypress-test-tiny/tree/opens-new-tab |
The problem with the example is that it is a complicated site with console errors that might or might not matter. If you had a small page with those video cards and they did not work correctly I would appreciate it. On the current media url it is hard to determine the problem
…Sent from my iPhone
On Jan 27, 2021, at 15:57, sinthujan24 ***@***.***> wrote:
@bahmutov The code snippets mentioned in #14757 (comment) are the minimal reproducible steps.
Did you want me to commit this to https://github.com/cypress-io/cypress-test-tiny/tree/opens-new-tab
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@bahmutov Please use the below example
Hover issue:
|
I have updated the reproducible example in https://github.com/cypress-io/cypress-test-tiny/tree/opens-new-tab There is a click on the video player that is handled by Preact which I cannot figure out where it is going, since this is minified production code. Everyone is welcome to trace it and figure out why the behavior during testing is different. |
|
This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided. |
Current behavior
Desired behavior
Test code to reproduce
Versions
Mac: Catalina 10.15.7
Chrome: Version 87.0.4280.141 (Official Build) (x86_64)
Cypress: Version 6.1.0 (6.1.0.531243)
The text was updated successfully, but these errors were encountered: