Revert "allow e2e tests to pass https options"

This reverts commit 06efeff.
cypress-io · Jan 9, 2020 · f4e3b12 · f4e3b12
1 parent 06efeff
commit f4e3b12
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/https-proxy/lib/proxy.coffee b/packages/https-proxy/lib/proxy.coffee
@@ -10,7 +10,7 @@ module.exports = {
   reset: ->
     Server.reset()
 
-  httpsServer: (onRequest, options) ->
-    require("../test/helpers/https_server").create(onRequest, options)
+  httpsServer: (onRequest) ->
+    require("../test/helpers/https_server").create(onRequest)
 
 }
diff --git a/packages/https-proxy/test/helpers/https_server.coffee b/packages/https-proxy/test/helpers/https_server.coffee
@@ -1,4 +1,3 @@
-_ = require('lodash')
 https = require("https")
 Promise = require("bluebird")
 { allowDestroy } = require("@packages/network")
@@ -14,8 +13,8 @@ defaultOnRequest = (req, res) ->
 
 servers = []
 
-create = (onRequest, options) ->
-  https.createServer(_.merge({}, certs, options), onRequest ? defaultOnRequest)
+create = (onRequest) ->
+  https.createServer(certs, onRequest ? defaultOnRequest)
 
 module.exports = {
   create

diff --git a/packages/server/test/support/helpers/e2e.js b/packages/server/test/support/helpers/e2e.js
@@ -151,14 +151,14 @@ const ensurePort = function (port) {
 
 const startServer = function (obj) {
   let s; let srv
-  const { onServer, port, https, httpsOptions } = obj
+  const { onServer, port, https } = obj
 
   ensurePort(port)
 
   const app = express()
 
   if (https) {
-    srv = httpsProxy.httpsServer(app, httpsOptions)
+    srv = httpsProxy.httpsServer(app)
   } else {
     srv = http.Server(app)
   }