Adding tests

.circleci/workflows.yml

@@ -822,7 +822,7 @@ commands:
                       name: Run tests using browser "<<parameters.browser>>"
                       working_directory: /tmp/<<parameters.repo>>/<<parameters.folder>>
                       command: |
-                        <<parameters.command>> --browser <<parameters.browser>>
+                        <<parameters.command>> --browser <<parameters.browser>> --record false
             - unless:
                 condition: <<parameters.browser>>
                 steps:
@@ -839,7 +839,7 @@ commands:
                   - run:
                       name: Run tests using browser "<<parameters.browser>>"
                       working_directory: /tmp/<<parameters.repo>>
-                      command: <<parameters.command>> --browser <<parameters.browser>>
+                      command: <<parameters.command>> --browser <<parameters.browser>> --record false
             - unless:
                 condition: <<parameters.browser>>
                 steps:

packages/telemetry/src/span-exporters/cloud-span-exporter.ts

@@ -111,13 +111,11 @@ export class OTLPTraceExporter extends OTLPTraceExporterHttp {
   }
 
   abortDelayedItems () {
-    if (this.headers.Authorization) {
-      this.delayedItemsToExport.forEach((item) => {
-        item.onError(new Error('Spans cannot be sent, exporter has unmet requirements, either project id or record key are undefined.'))
-      })
+    this.delayedItemsToExport.forEach((item) => {
+      item.onError(new Error('Spans cannot be sent, exporter has unmet requirements, either project id or record key are undefined.'))
+    })
 
-      this.delayedItemsToExport = []
-    }
+    this.delayedItemsToExport = []
   }
 
   /**
@@ -138,7 +136,7 @@ export class OTLPTraceExporter extends OTLPTraceExporterHttp {
       return
     }
 
-    if (this.enc && this.requirementsToExport === 'unmet') {
+    if (this.requirementsToExport === 'unmet') {
       onError(new Error('Spans cannot be sent, exporter has unmet requirements, either project id or record key are undefined.'))
     }
 

packages/telemetry/test/span-exporters/cloud-span-exporter.spec.ts

@@ -11,13 +11,15 @@ describe('cloudSpanExporter', () => {
       const exporter = new OTLPTraceExporter(genericRequest)
 
       expect(exporter.headers['x-cypress-encrypted']).to.equal('1')
+      expect(exporter.requirementsToExport).to.equal('unknown')
       expect(exporter.enc).to.not.be.undefined
     })
 
     it('does not set encrypted header if not set', () => {
       const exporter = new OTLPTraceExporter()
 
       expect(exporter.headers['x-cypress-encrypted']).to.be.undefined
+      expect(exporter.requirementsToExport).to.equal('met')
       expect(exporter.enc).to.be.undefined
     })
   })
@@ -42,15 +44,20 @@ describe('cloudSpanExporter', () => {
       expect(callCount).to.equal(1)
     })
 
-    it('does nothing if id is not passed', () => {
-      const exporter = new OTLPTraceExporter()
+    it('sets requirements to unmet if id is not passed', () => {
+      const exporter = new OTLPTraceExporter(genericRequest)
 
       let callCount = 0
+      let abortCallCount = 0
 
       exporter.setAuthorizationHeader = () => {
         callCount++
       }
 
+      exporter.abortDelayedItems = () => {
+        abortCallCount++
+      }
+
       expect(exporter.headers['x-project-id']).to.be.undefined
       expect(exporter.projectId).to.be.undefined
 
@@ -59,6 +66,9 @@ describe('cloudSpanExporter', () => {
       expect(exporter.headers['x-project-id']).to.be.undefined
       expect(exporter.projectId).to.be.undefined
       expect(callCount).to.equal(0)
+
+      expect(exporter.requirementsToExport).to.equal('unmet')
+      expect(abortCallCount).to.equal(1)
     })
   })
 
@@ -80,21 +90,29 @@ describe('cloudSpanExporter', () => {
       expect(callCount).to.equal(1)
     })
 
-    it('does nothing if record key is not passed', () => {
-      const exporter = new OTLPTraceExporter()
+    it('sets requirements to unmet  if record key is not passed', () => {
+      const exporter = new OTLPTraceExporter(genericRequest)
 
       let callCount = 0
+      let abortCallCount = 0
 
       exporter.setAuthorizationHeader = () => {
         callCount++
       }
 
+      exporter.abortDelayedItems = () => {
+        abortCallCount++
+      }
+
       expect(exporter.recordKey).to.be.undefined
 
       exporter.attachRecordKey(undefined)
 
       expect(exporter.recordKey).to.be.undefined
       expect(callCount).to.equal(0)
+
+      expect(exporter.requirementsToExport).to.equal('unmet')
+      expect(abortCallCount).to.equal(1)
     })
   })
 
@@ -109,10 +127,9 @@ describe('cloudSpanExporter', () => {
 
       const authorization = exporter.headers.Authorization
 
-      console.log('auth', authorization)
-
       // MTIzOjQ1Ng== is 123:456 base64 encoded
       expect(authorization).to.equal(`Basic MTIzOjQ1Ng==`)
+      expect(exporter.requirementsToExport).to.equal('met')
     })
   })
 
@@ -206,6 +223,24 @@ describe('cloudSpanExporter', () => {
     })
   })
 
+  describe('abortDelayedItems', () => {
+    it('aborts any delayed items', (done) => {
+      const exporter = new OTLPTraceExporter()
+
+      exporter.delayedItemsToExport.push({
+        serviceRequest: 'req',
+        onSuccess: () => {},
+        onError: (error) => {
+          expect(error.message).to.equal('Spans cannot be sent, exporter has unmet requirements, either project id or record key are undefined.')
+          done()
+        },
+      })
+
+      exporter.abortDelayedItems()
+      expect(exporter.delayedItemsToExport.length).to.equal(0)
+    })
+  })
+
   describe('send', () => {
     it('returns if shutdownOnce.isCalled is true', () => {
       const exporter = new OTLPTraceExporter()
@@ -395,5 +430,30 @@ describe('cloudSpanExporter', () => {
       expect(exporter.delayedItemsToExport.length).to.equal(1)
       expect(exporter.delayedItemsToExport[0].serviceRequest).to.equal('string')
     })
+
+    it('errors if requirements are unmet', (done) => {
+      const exporter = new OTLPTraceExporter()
+
+      exporter.requirementsToExport = 'unmet'
+
+      exporter.convert = (objects) => {
+        throw 'convert should not be called'
+      }
+
+      exporter.sendWithHttp = (collector, body, contentType, resolve, reject) => {
+        throw 'sendWithHttp should not be called'
+      }
+
+      const onSuccess = () => {
+        throw 'onSuccess should not be called'
+      }
+
+      const onError = (error) => {
+        expect(error.message).to.equal('Spans cannot be sent, exporter has unmet requirements, either project id or record key are undefined.')
+        done()
+      }
+
+      exporter.send('string', onSuccess, onError)
+    })
   })
 })