Merge branch 'develop' into chore/fix_contributor_ci_run

.circleci/workflows.yml

@@ -30,7 +30,7 @@ mainBuildFilters: &mainBuildFilters
         - /^release\/\d+\.\d+\.\d+$/
         # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
         - 'update-v8-snapshot-cache-on-develop'
-        - 'ryanm/feat/unify-cdp-approach-in-electron'
+        - 'matth/chore/add-telemetry-realworld-app'
 
 # usually we don't build Mac app - it takes a long time
 # but sometimes we want to really confirm we are doing the right thing
@@ -139,7 +139,7 @@ commands:
       - run:
           name: Check current branch to persist artifacts
           command: |
-            if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "update-v8-snapshot-cache-on-develop" && "$CIRCLE_BRANCH" != "ryanm/feat/unify-cdp-approach-in-electron" ]]; then
+            if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "update-v8-snapshot-cache-on-develop" && "$CIRCLE_BRANCH" != "matth/chore/add-telemetry-realworld-app" ]]; then
               echo "Not uploading artifacts or posting install comment for this branch."
               circleci-agent step halt
             fi
@@ -753,7 +753,7 @@ commands:
       command:
         description: Test command to run to start Cypress tests
         type: string
-        default: "yarn cypress:run"
+        default: "CYPRESS_INTERNAL_ENABLE_TELEMETRY=1 CYPRESS_RECORD_KEY=$MAIN_RECORD_KEY CYPRESS_PROJECT_ID=ypt4pf yarn cypress:run"
       # if the repo to clone and test is a monorepo, you can
       # run tests inside a specific subfolder
       folder:
@@ -823,7 +823,7 @@ commands:
                       name: Run tests using browser "<<parameters.browser>>"
                       working_directory: /tmp/<<parameters.repo>>/<<parameters.folder>>
                       command: |
-                        <<parameters.command>> -- --browser <<parameters.browser>>
+                        <<parameters.command>> --browser <<parameters.browser>> --record false
             - unless:
                 condition: <<parameters.browser>>
                 steps:
@@ -840,7 +840,7 @@ commands:
                   - run:
                       name: Run tests using browser "<<parameters.browser>>"
                       working_directory: /tmp/<<parameters.repo>>
-                      command: <<parameters.command>> -- --browser <<parameters.browser>>
+                      command: <<parameters.command>> --browser <<parameters.browser>> --record false
             - unless:
                 condition: <<parameters.browser>>
                 steps:
@@ -1945,20 +1945,6 @@ jobs:
           command: yarn workspace @cypress/mount-utils build
       - store-npm-logs
 
-  npm-xpath:
-    <<: *defaults
-    resource_class: small
-    steps:
-      - restore_cached_workspace
-      - run:
-          name: Run tests
-          command: yarn workspace @cypress/xpath cy:run
-      - store_test_results:
-          path: npm/xpath/test_results
-      - store_artifacts:
-          path: npm/xpath/test_results
-      - store-npm-logs
-
   npm-grep:
     <<: *defaults
     resource_class: small
@@ -2768,6 +2754,7 @@ linux-x64-workflow: &linux-x64-workflow
         requires:
           - create-build-artifacts
     - test-binary-against-cypress-realworld-app:
+        context: test-runner:cypress-record-key
         <<: *mainBuildFilters
         requires:
           - create-build-artifacts

.github/workflows/stale_issues_and_pr_cleanup.yml

@@ -32,7 +32,7 @@ permissions:
   issues: write
   pull-requests: write
 env:
-  DEFAULT_DEBUG_ONLY: true
+  DEFAULT_DEBUG_ONLY: false
   DEFAULT_MAX_OPS: 3000
   DEFAULT_DAYS_BEFORE_STALE: 180
   DEFAULT_DAYS_BEFORE_CLOSE: 14

.gitignore

@@ -78,8 +78,6 @@ system-tests/lib/fixtureDirs.ts
 # from npm/webpack-dev-server
 /npm/webpack-dev-server/cypress/videos
 
-# from npm/xpath
-/npm/xpath/cypress/videos
 # from npm/grep
 /npm/grep/cypress/videos
 

CHANGELOG.md

@@ -14,4 +14,3 @@
 - [`@cypress/webpack-batteries-included-preprocessor`](https://github.com/cypress-io/cypress/blob/develop/npm/webpack-batteries-included-preprocessor/CHANGELOG.md)
 - [`@cypress/webpack-dev-server`](https://github.com/cypress-io/cypress/blob/develop/npm/webpack-dev-server/CHANGELOG.md)
 - [`@cypress/webpack-preprocessor`](https://github.com/cypress-io/cypress/blob/develop/npm/webpack-preprocessor/CHANGELOG.md)
-- [`@cypress/xpath`](https://github.com/cypress-io/cypress/blob/develop/npm/xpath/CHANGELOG.md)

CONTRIBUTING.md

@@ -197,7 +197,6 @@ Here is a list of the npm packages in this repository:
  | [webpack-batteries-included-preprocessor](./npm/webpack-batteries-included-preprocessor)     | `@cypress/webpack-batteries-included-preprocessor`    | Cypress preprocessor for bundling JavaScript via webpack with dependencies included and support for various ES features, TypeScript, and CoffeeScript.  |
  | [webpack-dev-server](./npm/webpack-dev-server)     | `@cypress/webpack-dev-server`    | Webpack powered dev server for Component Testing.                |
  | [webpack-preprocessor](./npm/webpack-preprocessor)     | `@cypress/webpack-preprocessor`    | Cypress preprocessor for bundling JavaScript via webpack.  |
- | [xpath](./npm/xpath)                                     | `@cypress/xpath`                    | Adds XPath command to Cypress.io test runner        |
 
 We try to tag all issues with a `pkg/` or `npm/` tag describing the appropriate package the work is required in. For public packages, we use their qualified package name: For example, issues relating to the  webpack preprocessor are tagged under [`npm: @cypress/webpack-preprocessor`](https://github.com/cypress-io/cypress/labels/npm%3A%20%40cypress%2Fwebpack-preprocessor) label and issues related to the `driver` package are tagged with the [`pkg/driver`](https://github.com/cypress-io/cypress/labels/pkg%2Fdriver) label.
 

cli/CHANGELOG.md

@@ -1,4 +1,13 @@
 <!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
+## 12.13.1
+
+_Released 06/06/2023 (PENDING)_
+
+**Dependency Updates:**
+
+- Upgraded [`find-process`](https://www.npmjs.com/package/find-process) from `1.4.1` to `1.4.7` to address this [Synk](https://security.snyk.io/vuln/SNYK-JS-FINDPROCESS-1090284) security vulnerability. Addressed in [#26631](https://github.com/cypress-io/cypress/pull/26906).
+- Upgraded [`firefox-profile`](https://www.npmjs.com/package/firefox-profile) from `4.0.0` to `4.3.2` to address security vulnerabilities within sub-dependencies. Addressed in [#26631](https://github.com/cypress-io/cypress/pull/26912).
+
 ## 12.13.0
 
 _Released 05/23/2023_

npm/xpath/README.md

@@ -1,82 +1,3 @@
 # @cypress/xpath
 
-> Adds XPath command to [Cypress.io](https://www.cypress.io) test runner
-
-## Install with npm
-
-```shell
-npm install -D @cypress/xpath
-```
-
-## Install with Yarn
-
-```shell
-yarn add @cypress/xpath --dev
-```
-
-Then include in your project's [support file](https://on.cypress.io/support-file)
-
-```js
-require('@cypress/xpath');
-```
-
-## Use
-
-After installation your `cy` object will have `xpath` command.
-
-```js
-it('finds list items', () => {
-  cy.xpath('//ul[@class="todo-list"]//li').should('have.length', 3);
-});
-```
-
-You can also chain `xpath` off of another command.
-
-```js
-it('finds list items', () => {
-  cy.xpath('//ul[@class="todo-list"]').xpath('./li').should('have.length', 3);
-});
-```
-
-As with other cy commands, it is scoped by `cy.within()`.
-
-```js
-it('finds list items', () => {
-  cy.xpath('//ul[@class="todo-list"]').within(() => {
-    cy.xpath('./li').should('have.length', 3);
-  });
-});
-```
-
-**note:** you can test XPath expressions from DevTools console using `$x(...)` function, for example `$x('//div')` to find all divs.
-
-See [cypress/e2e/spec.cy.js](cypress/e2e/spec.cy.js)
-
-## Beware the XPath // trap
-
-In XPath the expression // means something very specific, and it might not be what you think. Contrary to common belief, // means "anywhere in the document" not "anywhere in the current context". As an example:
-
-```js
-cy.xpath('//body').xpath('//script');
-```
-
-You might expect this to find all script tags in the body, but actually, it finds all script tags in the entire document, not only those in the body! What you're looking for is the .// expression which means "any descendant of the current node":
-
-```js
-cy.xpath('//body').xpath('.//script');
-```
-
-The same thing goes for within:
-
-```js
-cy.xpath('//body').within(() => {
-  cy.xpath('.//script');
-});
-```
-
-
-For more, see [Intelligent Code Completion](https://on.cypress.io/intellisense)
-
-## License
-
-This project is licensed under the terms of the [MIT license](/LICENSE.md).
+> @cypress/xpath has been deprecated and is no longer supported.