fix: change how tsconfig is aliased in webpack-batteries-included-pre…

…processor (#27706)

* chore: change how tsconfig is aliased in webpack-batteries-included-preprocessor

* use --target-reference so snyk analyzes current branch

* fix missing space

* use pull_request instead of pull_request_target for snyk actions

.github/workflows/snyk_sca_scan.yaml

@@ -1,15 +1,15 @@
 name: Snyk Software Composition Analysis Scan
-# This git workflow leverages Snyk actions to perform a Software Composition 
+# This git workflow leverages Snyk actions to perform a Software Composition
 # Analysis scan on our Opensource libraries upon Pull Requests to the
-# "develop" branch. We use this as a control to prevent vulnerable packages 
-# from being introduced into the codebase. 
+# "develop" branch. We use this as a control to prevent vulnerable packages
+# from being introduced into the codebase.
 # Enhancements were made to this action to build the yarn packages to reduce
-# Snyk scan errors that were complaining about the yarn.locks etc.  Also 
+# Snyk scan errors that were complaining about the yarn.locks etc.  Also
 # implemented PAT token for actions to resolve an issue with the action not
 # running and reporting back to the PR status checks
 on:
-  pull_request_target:
-    branches: 
+  pull_request:
+    branches:
       - develop
 jobs:
   Snyk_SCA_Scan:

.github/workflows/snyk_static_analysis_scan.yaml

@@ -1,11 +1,11 @@
 name: Snyk Static Analysis Scan
-# This git workflow leverages Snyk actions to perform a Static Application 
+# This git workflow leverages Snyk actions to perform a Static Application
 # Testing scan (SAST) on our first-party code upon Pull Requests to the
-# "develop" branch. We use this as a control to prevent vulnerabilities 
-# from being introduced into the codebase. 
+# "develop" branch. We use this as a control to prevent vulnerabilities
+# from being introduced into the codebase.
 on:
-  pull_request_target:
-    branches: 
+  pull_request:
+    branches:
       - develop
 jobs:
   Snyk_SAST_Scan :

npm/webpack-batteries-included-preprocessor/index.js

@@ -27,8 +27,8 @@ const addTypeScriptConfig = (file, options) => {
 
   const TsconfigPathsPlugin = require('tsconfig-paths-webpack-plugin')
   // node will try to load a projects tsconfig.json instead of the node
-  // package using require('tsconfig'), so we alias it as 'tsconfig-package'
-  const configFile = require('tsconfig-package').findSync(path.dirname(file.filePath))
+  // package using require('tsconfig'), so we alias it as 'tsconfig-aliased-for-wbip'
+  const configFile = require('tsconfig-aliased-for-wbip').findSync(path.dirname(file.filePath))
 
   webpackOptions.module.rules.push({
     test: /\.tsx?$/,

npm/webpack-batteries-included-preprocessor/package.json

@@ -37,7 +37,7 @@
     "stream-http": "^3.2.0",
     "timers-browserify": "^2.0.12",
     "ts-loader": "9.4.4",
-    "tsconfig-package": "npm:tsconfig@^7.0.0",
+    "tsconfig-aliased-for-wbip": "npm:tsconfig@^7.0.0",
     "tsconfig-paths-webpack-plugin": "^3.5.2",
     "tty-browserify": "^0.0.1",
     "url": "^0.11.1",

yarn.lock

@@ -28692,7 +28692,7 @@ ts-pnp@^1.1.6:
   resolved "https://registry.yarnpkg.com/ts-pnp/-/ts-pnp-1.1.6.tgz#389a24396d425a0d3162e96d2b4638900fdc289a"
   integrity sha512-CrG5GqAAzMT7144Cl+UIFP7mz/iIhiy+xQ6GGcnjTezhALT02uPMRw7tgDSESgB5MsfKt55+GPWw4ir1kVtMIQ==
 
-"tsconfig-package@npm:tsconfig@^7.0.0":
+"tsconfig-aliased-for-wbip@npm:tsconfig@^7.0.0":
   version "7.0.0"
   resolved "https://registry.yarnpkg.com/tsconfig/-/tsconfig-7.0.0.tgz#84538875a4dc216e5c4a5432b3a4dec3d54e91b7"
   integrity sha512-vZXmzPrL+EmC4T/4rVlT2jNVMWCi/O4DIiSj3UHg1OE5kCKbk4mfrXc6dZksLgRM/TZlKnousKH9bbTazUWRRw==