fixes for cloudValidations - run ci

.circleci/workflows.yml

@@ -201,6 +201,7 @@ commands:
           command: |
             source ./scripts/ensure-node.sh
             yarn gulp buildProd
+            yarn gulp syncCloudValidations
       - run:
           name: Build packages
           command: |

.gitignore

@@ -397,3 +397,6 @@ tooling/v8-snapshot/cache/dev-win32
 tooling/v8-snapshot/cache/prod-darwin
 tooling/v8-snapshot/cache/prod-linux
 tooling/v8-snapshot/cache/prod-win32
+
+# Cloud API validations
+system-tests/lib/validations

package.json

@@ -277,4 +277,4 @@
     "sharp": "0.29.3",
     "vue-template-compiler": "2.6.12"
   }
-}
+}

scripts/gulp/gulpfile.ts

@@ -20,7 +20,7 @@ import { execSync } from 'child_process'
 import { webpackReporter, webpackRunner } from './tasks/gulpWebpack'
 import { e2eTestScaffold, e2eTestScaffoldWatch } from './tasks/gulpE2ETestScaffold'
 import dedent from 'dedent'
-import { syncCloudValidations } from './tasks/gulpSyncValidations'
+import { ensureCloudValidations, syncCloudValidations } from './tasks/gulpSyncValidations'
 
 if (process.env.CYPRESS_INTERNAL_VITE_DEV) {
   process.env.CYPRESS_INTERNAL_VITE_APP_PORT ??= '3333'
@@ -266,6 +266,7 @@ gulp.task(makePackage)
  * here for debugging, e.g. `yarn gulp syncRemoteGraphQL`
  *------------------------------------------------------------------------**/
 
+gulp.task(ensureCloudValidations)
 gulp.task(syncCloudValidations)
 gulp.task(syncRemoteGraphQL)
 gulp.task(generateFrontendSchema)

scripts/gulp/tasks/gulpSyncValidations.ts

@@ -2,7 +2,16 @@ import fs from 'fs-extra'
 import path from 'path'
 import crossFetch from 'cross-fetch'
 
-const VALIDATION_BASE = process.env.CY_CLOUD_VALIDATION_BASE ?? 'http://localhost:1234'
+const INTERNAL_CLOUD_ENV = process.env.CYPRESS_INTERNAL_ENV || 'production'
+
+const CY_CLOUD_VALIDATION_BASE = {
+  test: 'https://api.cypress.io',
+  production: 'https://api.cypress.io',
+  staging: 'https://api-staging.cypress.io',
+  development: 'http://localhost:1234',
+}
+
+const VALIDATION_BASE = CY_CLOUD_VALIDATION_BASE[INTERNAL_CLOUD_ENV]
 
 const OUTPUT_FOLDER = path.join(__dirname, '../../../system-tests/lib/validations')
 
@@ -23,3 +32,9 @@ export async function syncCloudValidations () {
     fs.promises.writeFile(path.join(OUTPUT_FOLDER, 'cloudValidations.d.ts'), validationsTypes),
   ])
 }
+
+export async function ensureCloudValidations () {
+  if (!fs.existsSync(path.join(OUTPUT_FOLDER, 'cloudValidations.js')) || !fs.existsSync(path.join(OUTPUT_FOLDER, 'cloudValidations.d.ts'))) {
+    await syncCloudValidations()
+  }
+}

system-tests/__snapshots__/record_spec.js

@@ -2831,7 +2831,7 @@ exports['e2e record capture-protocol passing retrieves the capture protocol 1']
 
   (Screenshots)
 
-  -  /XXX/XXX/XXX/cypress/screenshots/record_pass.cy.js/yay it passes.png                 (800x2044)
+  -  /XXX/XXX/XXX/cypress/screenshots/record_pass.cy.js/yay it passes.png                 (400x1022)
 
 
   (Uploading Results)

system-tests/lib/serverStub.ts

@@ -221,7 +221,7 @@ const getSchemaErr = (tag, err, schema) => {
     errors: err.errors,
     object: err.object,
     example: err.example,
-    message: `${tag} should follow ${schema} schema`,
+    message: `${tag} should follow ${schema.join('@')} schema`,
   }
 }