avoid unnamed snapshots in same test

cypress-io · Feb 1, 2022 · 4135fe1 · 4135fe1
1 parent 9a5d20f
commit 4135fe1
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/packages/app/src/components/FileMatch.cy.tsx b/packages/app/src/components/FileMatch.cy.tsx
@@ -50,11 +50,11 @@ describe('<FileMatch />', { viewportWidth: 600, viewportHeight: 300 }, () => {
     describe('expanding/collapsing', () => {
       it('can be expanded and collapsed by the extension button', () => {
         cy.get(extensionInputSelector).should('not.exist')
-        cy.percySnapshot()
+        cy.percySnapshot('before expand')
         cy.get(fileMatchButtonSelector).click()
         .get(extensionInputSelector).should('be.visible')
 
-        cy.percySnapshot()
+        cy.percySnapshot('after expand')
         cy.get(fileMatchButtonSelector).click()
         .get(extensionInputSelector).should('not.exist')
       })

diff --git a/packages/app/src/runner/SnapshotToggle.cy.tsx b/packages/app/src/runner/SnapshotToggle.cy.tsx
@@ -6,29 +6,29 @@ describe('<SnapshotToggle/>', () => {
 
     cy.mount(() => (<SnapshotToggle class="m-20" messages={messages} />))
 
-    cy.percySnapshot()
+    cy.percySnapshot('before')
     .get('body')
     .findByText('2')
     .click()
     .parent()
     .findByText('1')
     .click()
-    .percySnapshot()
+    .percySnapshot('after')
   })
 
   it('renders longer text', () => {
     const messages = [{ text: 'Request', id: '1' }, { text: 'Response', id: '2' }]
 
     cy.mount(() => (<SnapshotToggle class="m-20" messages={messages} />))
 
-    cy.percySnapshot()
+    cy.percySnapshot('before')
     .get('body')
     .findByText('Request')
     .click()
     .parent()
     .findByText('Response')
     .click()
-    .percySnapshot()
+    .percySnapshot('after')
   })
 
   it('emits a select event with the active message', () => {

diff --git a/packages/app/src/settings/SettingsCard.cy.tsx b/packages/app/src/settings/SettingsCard.cy.tsx
@@ -23,11 +23,11 @@ describe('<SettingsCard />', () => {
     cy.get(contentSelector).should('not.exist')
     cy.findByText(title).click()
     cy.get(contentSelector).should('be.visible')
-    cy.percySnapshot()
+    cy.percySnapshot('expanded state')
     cy.findByText(title).click()
     .get(contentSelector).should('not.exist')
 
-    cy.percySnapshot()
+    cy.percySnapshot('collapsed state')
 
     // expected aria and keyboard behavior with space and enter keys:
     cy.get(collapsibleSelector).should('be.focused')

diff --git a/packages/app/src/specs/SpecsList.cy.tsx b/packages/app/src/specs/SpecsList.cy.tsx
@@ -28,9 +28,7 @@ describe('<SpecsList />', { keystrokeDelay: 0 }, () => {
 
       cy.mountFragment(Specs_SpecsListFragmentDoc, {
         onResult: (ctx) => {
-          if (!specs.length) {
-            specs = ctx.currentProject?.specs || []
-          }
+          specs = ctx.currentProject?.specs || []
 
           return ctx
         },