chore: remove low value percy snapshots

cypress-io · Jun 6, 2023 · 3312059 · 3312059
1 parent d610c51
commit 3312059
Show file tree

Hide file tree

Showing 43 changed files with 65 additions and 143 deletions.
diff --git a/packages/app/cypress/e2e/runner/cloud-debug-filter.cy.ts b/packages/app/cypress/e2e/runner/cloud-debug-filter.cy.ts
@@ -55,12 +55,6 @@ describe('cloud debug test filtering', () => {
     cy.get('@reporterPanel').then((el) => el.width(500))
     cy.get('@reporterPanel').percySnapshot('wide')
 
-    cy.get('@reporterPanel').then((el) => el.width(350))
-    cy.get('@reporterPanel').percySnapshot('medium')
-
-    cy.get('@reporterPanel').then((el) => el.width(250))
-    cy.get('@reporterPanel').percySnapshot('narrow')
-
     cy.get('@reporterPanel').then((el) => el.width(150))
     cy.get('@reporterPanel').percySnapshot('skinny')
   })

diff --git a/packages/app/src/components/SpecPatterns.cy.tsx b/packages/app/src/components/SpecPatterns.cy.tsx
@@ -9,8 +9,6 @@ describe('<SpecPatterns />', () => {
 
     cy.get('[data-cy="spec-pattern"]').contains('cypress/e2e/**/*.cy.{js,jsx,ts,tsx}')
     cy.get('[data-cy="file-match-indicator"]').contains('50 matches')
-
-    cy.percySnapshot()
   })
 
   it('renders component spec pattern', () => {

diff --git a/packages/app/src/debug/DebugContainer.cy.tsx b/packages/app/src/debug/DebugContainer.cy.tsx
@@ -169,40 +169,40 @@ describe('<DebugContainer />', () => {
       it('renders', () => {
         mountTestRun('allSkipped')
 
+        cy.findByTestId('collapsible').should('be.visible')
+        cy.contains('h3', 'Incomplete')
         cy.contains('The browser server never connected.').should('be.visible')
         cy.contains('2 of 3 specs skipped').should('be.visible')
-
-        cy.percySnapshot()
       })
     })
 
     context('no tests', () => {
       it('renders', () => {
         mountTestRun('noTests')
 
+        cy.findByTestId('collapsible').should('be.visible')
+        cy.contains('h3', 'Incomplete')
         cy.contains('Run has no tests').should('be.visible')
-
-        cy.percySnapshot()
       })
     })
 
     context('timed out', () => {
       it('renders with CI information', () => {
         mountTestRun('timedOutWithCi')
 
+        cy.findByTestId('collapsible').should('be.visible')
+        cy.contains('h3', 'Incomplete')
         cy.contains('Circle CI #1234').should('have.attr', 'href', 'https://circleci.com').should('be.visible')
         cy.contains('Archive this run to remove it').should('be.visible')
-
-        cy.percySnapshot()
       })
 
       it('renders without CI information', () => {
         mountTestRun('timedOutWithoutCi')
 
+        cy.findByTestId('collapsible').should('be.visible')
+        cy.contains('h3', 'Incomplete')
         cy.contains('Circle CI #1234').should('not.exist')
         cy.contains('Archive this run to remove it').should('be.visible')
-
-        cy.percySnapshot()
       })
     })
 

diff --git a/packages/app/src/debug/DebugFailedTest.cy.tsx b/packages/app/src/debug/DebugFailedTest.cy.tsx
@@ -139,8 +139,6 @@ describe('<DebugFailedTest/>', () => {
     ))
 
     assertRowContents(multipleTitleParts)
-
-    cy.percySnapshot()
   })
 
   it('tests multiple groups', { viewportWidth: 1200 }, () => {

diff --git a/packages/app/src/debug/DebugPendingRunCounts.cy.tsx b/packages/app/src/debug/DebugPendingRunCounts.cy.tsx
@@ -9,8 +9,6 @@ describe('<DebugPendingRunCounts />', () => {
     )
 
     cy.contains('2 of 20').should('be.visible')
-
-    cy.percySnapshot()
   })
 
   it('renders counts of zeros input is undefined', () => {
@@ -21,7 +19,5 @@ describe('<DebugPendingRunCounts />', () => {
     )
 
     cy.contains('0 of 0').should('be.visible')
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/debug/DebugPendingRunSplash.cy.tsx b/packages/app/src/debug/DebugPendingRunSplash.cy.tsx
@@ -4,17 +4,14 @@ describe('<DebugPendingRunSplash />', () => {
   it('renders as expected', () => {
     cy.mount(<DebugPendingRunSplash/>)
 
-    cy.contains('Failures will be displayed here')
-
-    cy.percySnapshot()
+    cy.findByTestId('title').contains('Testing in progress...')
+    cy.findByTestId('splash-subtitle').contains('Failures will be displayed here')
   })
 
   it('renders scheduled to complete message', () => {
     cy.mount(<DebugPendingRunSplash isCompletionScheduled={true}/>)
 
     cy.contains('Scheduled to complete...')
     cy.findByTestId('splash-subtitle').should('not.exist')
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/debug/DebugResults.cy.tsx b/packages/app/src/debug/DebugResults.cy.tsx
@@ -17,8 +17,6 @@ describe('<DebugResults />', () => {
         cy.get(`[title=${defaultMessages.runs.results.pending}]`).should('contain.text', cloudRun.totalPending)
       })
     })
-
-    cy.percySnapshot()
   })
 })
 

diff --git a/packages/app/src/debug/DebugRunNavigation.cy.tsx b/packages/app/src/debug/DebugRunNavigation.cy.tsx
@@ -241,8 +241,6 @@ describe('<DebugRunNavigation />', () => {
 
     cy.contains('We found more than 100 runs.').should('be.visible')
     cy.findByRole('link', { name: 'Go to Cypress Cloud to see all runs' }).should('be.visible').should('have.attr', 'href', 'https://cloud.cypress.io/projects/ypt4pf/?utm_medium=Debug+Tab&utm_campaign=Run+Navigation+Limit&utm_source=Binary%3A+Launchpad')
-
-    cy.percySnapshot()
   })
 
   describe('Switch to latest run button', () => {

diff --git a/packages/app/src/debug/DebugRunNavigationLimitMessage.cy.tsx b/packages/app/src/debug/DebugRunNavigationLimitMessage.cy.tsx
@@ -5,8 +5,6 @@ describe('DebugRunNavigationLimitMessage', () => {
     cy.mount(<DebugRunNavigationLimitMessage cloudProjectUrl="https://cloud.cypress.io/projects/ypt4pf/" />)
 
     cy.findByRole('link', { name: 'Go to Cypress Cloud to see all runs' }).should('be.visible').should('have.attr', 'href', 'https://cloud.cypress.io/projects/ypt4pf/?utm_medium=Debug+Tab&utm_campaign=Run+Navigation+Limit&utm_source=Binary%3A+Launchpad')
-
-    cy.percySnapshot()
   })
 
   it('does not render link if cloudProjectUrl is falsy', () => {

diff --git a/packages/app/src/debug/DebugSpecLimitBanner.cy.tsx b/packages/app/src/debug/DebugSpecLimitBanner.cy.tsx
@@ -19,9 +19,6 @@ describe('<DebugSpecLimitBanner />', () => {
     .and('match', /utm_campaign/)
     .and('match', /utm_source/)
 
-    cy.viewport(1000, 400)
-    cy.percySnapshot('large viewport')
-
     cy.viewport(600, 400)
     cy.percySnapshot('small viewport')
   })
@@ -34,8 +31,8 @@ describe('<DebugSpecLimitBanner />', () => {
       />
     ))
 
+    cy.get('li').contains('Cypress renders up to 100 failed test results')
+    cy.get('li').contains('This run has 120 failed tests')
     cy.get('a').should('not.exist')
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/debug/GroupedDebugFailedTest.cy.tsx b/packages/app/src/debug/GroupedDebugFailedTest.cy.tsx
@@ -85,7 +85,5 @@ describe('<GroupedDebugFailedTest/>', () => {
       cy.findByTestId('debug-artifacts').should('be.visible').children().should('have.length', 3)
       cy.findByTestId('stats-metadata').children().should('have.length', 3)
     }))
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/debug/LayeredBrowserIcons.cy.tsx b/packages/app/src/debug/LayeredBrowserIcons.cy.tsx
@@ -34,7 +34,5 @@ describe('<LayeredBrowserIcons/>', () => {
     cy.get('@allIcons').each((ele) => {
       cy.wrap(ele).find('svg').should('exist')
     })
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/navigation/SidebarNavigation.cy.tsx b/packages/app/src/navigation/SidebarNavigation.cy.tsx
@@ -64,8 +64,10 @@ describe('SidebarNavigation', () => {
     })
 
     cy.findByText('test-project').should('be.visible')
-    cy.findByTestId('sidebar-link-specs-page').should('have.class', 'router-link-active') // assert active link to prevent percy flake
-    cy.percySnapshot()
+    cy.findByTestId('sidebar-link-specs-page').should('be.visible').should('have.class', 'router-link-active').contains('Specs') // assert active link to prevent percy flake
+    cy.findAllByTestId('sidebar-link-runs-page').should('be.visible').should('not.have.class', 'router-link-active').contains('Runs')
+    cy.findAllByTestId('sidebar-link-debug-page').should('be.visible').should('not.have.class', 'router-link-active').contains('Debug')
+    cy.findAllByTestId('sidebar-link-settings-page').should('be.visible').should('not.have.class', 'router-link-active').contains('Settings')
   })
 
   it('automatically collapses when viewport decreases < 1024px', () => {
@@ -109,7 +111,10 @@ describe('SidebarNavigation', () => {
   it('opens a modal to switch testing type', { viewportWidth: 1280 }, () => {
     mountComponent()
     cy.findByTestId('sidebar-header').click()
-    cy.percySnapshot()
+    cy.get('button').contains('E2E Testing')
+    cy.contains('p', 'Build and test the entire experience of your application from end-to-end to ensure each flow matches your expectations.')
+    cy.get('button').contains('Component Testing')
+    cy.contains('p', 'Build and test your components from your design system in isolation in order to ensure each state matches your expectations.')
   })
 
   it('opens a modal to show keyboard shortcuts', () => {

diff --git a/packages/app/src/navigation/SidebarNavigationHeader.cy.tsx b/packages/app/src/navigation/SidebarNavigationHeader.cy.tsx
@@ -9,7 +9,6 @@ describe('SidebarNavigationHeader', () => {
 
     cy.get('[data-cy="testing-type-e2e"]').should('exist')
     cy.contains('test-project')
-    cy.percySnapshot()
   })
 
   it('renders component icon', () => {
@@ -26,6 +25,5 @@ describe('SidebarNavigationHeader', () => {
 
     cy.get('[data-cy="testing-type-component"]').should('exist')
     cy.contains('test-project')
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/runner/SpecRunnerHeaderOpenMode.cy.tsx b/packages/app/src/runner/SpecRunnerHeaderOpenMode.cy.tsx
@@ -177,8 +177,11 @@ describe('SpecRunnerHeaderOpenMode', { viewportHeight: 500 }, () => {
       },
     })
 
+    cy.findByTestId('select-browser').contains('Fake Browser')
+
     cy.get('[data-cy="select-browser"] > button img').should('have.attr', 'src', allBrowsersIcons.generic)
-    cy.percySnapshot()
+
+    cy.findByTestId('viewport').contains('500x500')
   })
 
   it('shows current viewport info', () => {

diff --git a/packages/app/src/runner/automation/AutomationDisconnected.cy.tsx b/packages/app/src/runner/automation/AutomationDisconnected.cy.tsx
@@ -5,7 +5,10 @@ describe('AutomationDisconnected', () => {
   it('should relaunch browser', () => {
     cy.mount(<AutomationDisconnected />)
 
-    cy.percySnapshot()
+    cy.findByTestId('collapsible').should('be.visible')
+    cy.contains('h3', 'The Cypress extension has disconnected.')
+    cy.contains('p', 'Cypress cannot run tests without this extension.')
+    cy.get('a').contains('Read more about browser management').should('have.attr', 'href', 'https://on.cypress.io/launching-browsers')
 
     const relaunchStub = cy.stub()
 

diff --git a/packages/app/src/runner/automation/AutomationMissing.cy.tsx b/packages/app/src/runner/automation/AutomationMissing.cy.tsx
@@ -14,7 +14,10 @@ describe('AutomationMissing', () => {
       },
     })
 
-    cy.percySnapshot()
+    cy.findByTestId('collapsible').should('be.visible')
+    cy.contains('h3', 'The Cypress extension is missing.')
+    cy.contains('p', 'Cypress cannot run tests without this extension. Please choose another browser.')
+    cy.findByTestId('external').contains('Read more about browser management').should('have.attr', 'href', 'https://on.cypress.io/launching-browsers')
 
     const selectBrowserStub = cy.stub()
 

diff --git a/packages/app/src/runs/RunsConnectSuccessAlert.spec.tsx b/packages/app/src/runs/RunsConnectSuccessAlert.spec.tsx
@@ -41,9 +41,6 @@ describe('<RunConnectSuccessAlert />', { viewportHeight: 400 }, () => {
           )
         },
       })
-
-      cy.viewport(1000, 800)
-      cy.percySnapshot()
     })
   })
 })
diff --git a/packages/app/src/settings/SettingsContainer.cy.tsx b/packages/app/src/settings/SettingsContainer.cy.tsx
@@ -10,8 +10,9 @@ describe('<SettingsContainer />', { viewportHeight: 800, viewportWidth: 900 }, (
   it('renders sections collapsed by default', () => {
     cy.findByTestId('settings').should('be.visible')
     cy.findByTestId('setting-expanded-container').should('not.exist')
-
-    cy.percySnapshot()
+    cy.findByText(defaultMessages.settingsPage.experiments.title).should('not.exist')
+    cy.findByText(defaultMessages.settingsPage.editor.title).should('not.exist')
+    cy.findByText(defaultMessages.settingsPage.projectId.title).should('not.exist')
   })
 
   it('expands and collapses project settings', () => {
@@ -20,7 +21,6 @@ describe('<SettingsContainer />', { viewportHeight: 800, viewportWidth: 900 }, (
     cy.findByText(defaultMessages.settingsPage.experiments.title).scrollIntoView().should('be.visible')
     cy.findByText(defaultMessages.settingsPage.specPattern.title).scrollIntoView().should('be.visible')
     cy.findByText(defaultMessages.settingsPage.config.title).scrollIntoView().should('be.visible')
-    cy.percySnapshot()
     cy.findByText('Project settings').click()
 
     cy.findByText(defaultMessages.settingsPage.experiments.title).should('not.exist')
@@ -32,7 +32,6 @@ describe('<SettingsContainer />', { viewportHeight: 800, viewportWidth: 900 }, (
     cy.findByText(defaultMessages.settingsPage.editor.title).should('be.visible')
     cy.findByText(defaultMessages.settingsPage.proxy.title).should('be.visible')
     cy.findByText(defaultMessages.settingsPage.testingPreferences.title).should('be.visible')
-    cy.percySnapshot()
 
     cy.findByText('Device settings').click()
 
@@ -43,7 +42,6 @@ describe('<SettingsContainer />', { viewportHeight: 800, viewportWidth: 900 }, (
     cy.contains('Cypress Cloud settings').click()
 
     cy.findByText(defaultMessages.settingsPage.projectId.title).scrollIntoView().should('be.visible')
-    cy.percySnapshot()
     cy.findByText('Cypress Cloud settings').click()
 
     cy.findByText(defaultMessages.settingsPage.projectId.title).should('not.exist')

diff --git a/packages/app/src/settings/SettingsSection.cy.tsx b/packages/app/src/settings/SettingsSection.cy.tsx
@@ -21,7 +21,5 @@ describe('<SettingsSection />', () => {
     .get('h1').should('contain.text', title)
     .get('p').should('contain.text', description)
     .get('code').should('contain.text', code)
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/settings/project/CloudSettings.cy.tsx b/packages/app/src/settings/project/CloudSettings.cy.tsx
@@ -64,6 +64,6 @@ describe('<CloudSettings />', () => {
 
     cy.findByText(defaultMessages.settingsPage.recordKey.title).should('not.exist')
 
-    cy.percySnapshot()
+    cy.get('button').contains('Connect to Cypress Cloud')
   })
 })
diff --git a/packages/app/src/settings/project/CodeBox.cy.tsx b/packages/app/src/settings/project/CodeBox.cy.tsx
@@ -9,7 +9,6 @@ describe('<CodeBox/>', () => {
       </div>))
 
     cy.findByText('123456789').should('be.visible')
-    cy.percySnapshot()
   })
 
   it('renders the confidential', () => {
@@ -21,7 +20,6 @@ describe('<CodeBox/>', () => {
     cy.findByText('123456789').should('not.exist')
     cy.get('[aria-label="Record Key Visibility Toggle"]').click()
     cy.findByText('123456789').should('be.visible')
-    cy.percySnapshot()
   })
 
   it('renders the icon', () => {

diff --git a/packages/app/src/settings/project/Config.cy.tsx b/packages/app/src/settings/project/Config.cy.tsx
@@ -16,13 +16,10 @@ describe('<Config/>', { viewportWidth: 1200, viewportHeight: 1600 }, () => {
     cy.get('[data-cy="config-code"]').contains('reporter')
     cy.get('[data-cy="config-legend"]').contains('default')
     cy.contains(defaultMessages.settingsPage.config.title)
-
     // TODO: write a support file helper for ignoring the {0} values etc
     each(defaultMessages.settingsPage.config.description.split('{0}'), (description) => {
       cy.contains(description)
     })
-
-    cy.percySnapshot()
   })
 
   it('matches up legends with values', () => {

diff --git a/packages/app/src/settings/project/ExperimentRow.cy.tsx b/packages/app/src/settings/project/ExperimentRow.cy.tsx
@@ -38,7 +38,5 @@ describe('<ExperimentRow />', () => {
       cy.findByText(expDisabled.description).should('be.visible')
       cy.findByText(expDisabled.key).should('be.visible')
     })
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/settings/project/Experiments.cy.tsx b/packages/app/src/settings/project/Experiments.cy.tsx
@@ -21,7 +21,5 @@ describe('<Experiments />', { viewportWidth: 800, viewportHeight: 600 }, () => {
       cy.contains(`[data-cy="experiment-${exp.field}"]`, expName)
       .should('contain', exp.value ? 'Enabled' : 'Disabled')
     })
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/settings/project/ProjectId.cy.tsx b/packages/app/src/settings/project/ProjectId.cy.tsx
@@ -25,7 +25,5 @@ describe('<ProjectId />', () => {
 
     cy.findByText(givenProjectId).should('be.visible')
     cy.findByText('Copy')
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/settings/project/ProjectSettings.cy.tsx b/packages/app/src/settings/project/ProjectSettings.cy.tsx
@@ -16,7 +16,5 @@ describe('<ProjectSettings />', () => {
     })
 
     cy.findByText(defaultMessages.settingsPage.experiments.title).should('be.visible')
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/settings/project/RecordKey.cy.tsx b/packages/app/src/settings/project/RecordKey.cy.tsx
@@ -46,7 +46,5 @@ describe('<RecordKey />', () => {
     cy.contains('button', defaultMessages.clipboard.copy)
     .should('be.visible')
     .and('not.be.disabled')
-
-    cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/settings/project/SpecPatterns.cy.tsx b/packages/app/src/settings/project/SpecPatterns.cy.tsx
@@ -18,7 +18,5 @@ describe('<SpecPatterns />', () => {
     cy.get('[data-cy="file-match-indicator"]').contains('50 matches')
     cy.get('[data-cy="spec-pattern"]').contains('cypress/e2e/**/*.cy.{js,jsx,ts,tsx}')
     cy.get('[data-cy="external"]').should('have.attr', 'href').and('eq', 'https://on.cypress.io/test-type-options')
-
-    cy.percySnapshot()
   })
 })
-Original file line number
+Diff line change
@@ Expand Up / @@ -139,8 +139,6 @@ describe('<DebugFailedTest/>', () => { @@
         ))
         assertRowContents(multipleTitleParts)
-        cy.percySnapshot()
       })
       it('tests multiple groups', { viewportWidth: 1200 }, () => {
@@ Expand Down @@