Skip to content

Commit

Permalink
add fixme issue to stack trace mismatches inside evaled context
Browse files Browse the repository at this point in the history
  • Loading branch information
AtofStryker committed Jun 4, 2024
1 parent 0c9e81e commit 307eb28
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/app/cypress/e2e/runner/reporter.command_errors.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@ describe('errors ui', {
})
})

// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
// leading to a small mismatch when linking stack traces back to the user's IDE from
// the command log.
it('cy.intercept', () => {
const verify = loadErrorSpec({
filePath: 'errors/intercept.cy.ts',
Expand Down
4 changes: 4 additions & 0 deletions packages/app/cypress/e2e/runner/reporter.errors.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@ describe('errors ui', {
})
})

// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
// leading to a small mismatch when linking stack traces back to the user's IDE from
// the command log.
it('typescript', () => {
const verify = loadErrorSpec({
filePath: 'errors/typescript.cy.ts',
Expand Down
8 changes: 8 additions & 0 deletions system-tests/projects/e2e/cypress/e2e/cy_origin_error.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ describe('cy.origin errors', () => {
})
})

// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
// leading to a small mismatch when linking stack traces back to the user's IDE from
// the command log.
verify('command failure', this, {
line: 16,
message: 'Expected to find element',
Expand All @@ -36,6 +40,10 @@ describe('cy.origin errors', () => {
})
})

// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
// leading to a small mismatch when linking stack traces back to the user's IDE from
// the command log.
verify('failure when using dependency', this, {
line: 30,
message: 'Expected to find element',
Expand Down
5 changes: 5 additions & 0 deletions system-tests/test/cy_origin_error_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ describe('e2e cy.origin errors', () => {
expect(stdout).to.contain('AssertionError')
expect(stdout).to.contain('Timed out retrying after 1ms: Expected to find element: `#doesnotexist`, but never found it.')

// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
// leading to a small mismatch when linking stack traces back to the user's IDE from
// the command log.

// check to make sure stack trace contains the 'cy.origin' source
expect(stdout).to.contain('webpack://e2e/./cypress/e2e/cy_origin_error.cy.ts:16')
expect(stdout).to.contain('webpack://e2e/./cypress/e2e/cy_origin_error.cy.ts:30')
Expand Down

0 comments on commit 307eb28

Please sign in to comment.