Skip to content

Commit

Permalink
chore: update v8 generation vars so that from scratch depends implies…
Browse files Browse the repository at this point in the history
… updating the metafile (#26472)
  • Loading branch information
ryanthemanuel authored Apr 28, 2023
1 parent 91cbc67 commit 296342c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion tooling/v8-snapshot/src/doctor/determine-deferred.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,11 @@ export async function determineDeferred (
deferredHash: currentHash,
}

if (!opts.nodeModulesOnly && process.env.V8_UPDATE_METAFILE && ['1', 'true'].includes(process.env.V8_UPDATE_METAFILE)) {
const updateMetafile = process.env.V8_UPDATE_METAFILE && ['1', 'true'].includes(process.env.V8_UPDATE_METAFILE)
const generateFromScratch = process.env.V8_SNAPSHOT_FROM_SCRATCH && ['1', 'true'].includes(process.env.V8_SNAPSHOT_FROM_SCRATCH)

// Only update the metafile if we are generating the full snapshot and we have either explicitly requested to update it or generating from scratch
if (!opts.nodeModulesOnly && (updateMetafile || generateFromScratch)) {
await fs.promises.writeFile(
jsonPath,
JSON.stringify(updatedMeta, null, 2),
Expand Down

4 comments on commit 296342c

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 296342c Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.11.1/linux-arm64/develop-296342c7c4d0cd109080272625986481de6b157a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 296342c Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.11.1/linux-x64/develop-296342c7c4d0cd109080272625986481de6b157a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 296342c Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.11.1/darwin-arm64/develop-296342c7c4d0cd109080272625986481de6b157a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 296342c Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.11.1/darwin-x64/develop-296342c7c4d0cd109080272625986481de6b157a/cypress.tgz

Please sign in to comment.