fix(driver): dynamic intercept aliases shown with name instead of no …

…alias (#28326)

Co-authored-by: jordanpowell88 <[email protected]>

cli/CHANGELOG.md

@@ -10,6 +10,7 @@ _Released 11/21/2023 (PENDING)_
 
 **Bugfixes:**
 
+- Fixed an issue where dynamic intercept aliases now show with alias name instead of "no alias" in driver. Addresses [#24653](https://github.com/cypress-io/cypress/issues/24653)
 - Fixed an issue where [aliasing individual requests](https://docs.cypress.io/api/commands/intercept#Aliasing-individual-requests) with `cy.intercept()` led to an error when retrieving all of the aliases with `cy.get(@alias.all)` . Addresses [#25448](https://github.com/cypress-io/cypress/issues/25448)
 - The URL of the application under test and command error "Learn more" links now open externally instead of in the Cypress-launched browser. Fixes [#24572](https://github.com/cypress-io/cypress/issues/24572).
 

packages/driver/cypress/e2e/commands/net_stubbing.cy.ts

@@ -3809,6 +3809,31 @@ describe('network stubbing', { retries: 15 }, function () {
           $.get(url)
         })
         .wait('@fromInterceptor')
+        .then(() => {
+          const log = cy.queue.logs({
+            displayName: 'xhr',
+          })[0]
+
+          const renderProps = log.get('renderProps')()
+
+          expect(renderProps.interceptions).to.have.length(1)
+          expect(renderProps.interceptions[0]).to.have.property('alias')
+          expect(renderProps.interceptions[0].alias).to.eq('fromInterceptor')
+        })
+      })
+
+      it('can dynamically alias the request and get with @alias.all', function () {
+        const url = uniqueRoute('/foo')
+
+        cy.intercept(`${url}*`, (req) => {
+          req.alias = 'fromInterceptor'
+        })
+        .then(() => {
+          $.get(url)
+          $.get(url)
+        })
+        .wait('@fromInterceptor').wait('@fromInterceptor')
+        .get('@fromInterceptor.all').should('have.length', 2)
       })
 
       it('can time out on a dynamic alias', function (done) {

packages/driver/src/cy/commands/waiting.ts

@@ -90,6 +90,10 @@ export default (Commands, Cypress, cy, state) => {
       const req = waitForRoute(alias, state, type)
 
       if (req) {
+        // Attach alias to request to ensure driver access to
+        // dynamic aliases. See #24653
+        req.request.alias = alias
+
         return req
       }