Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to npm consistently #5757

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

MikeMcC399
Copy link
Contributor

Issue

The repo refers to npm using both upper case "NPM" and lower case "npm".

Usage of capitalized "NPM" is however not in line with npm branding guidelines which state:

npm should never be capitalized unless it is being displayed in a location that is customarily all-capitals (ex. titles on man pages).

Changes

Change all relevant usage of "NPM" to lower case "npm", aligning with npm branding guidelines.

Only one of the instances of "NPM" was in a title. This was in an external blog article and this was left in place.

Copy link

netlify bot commented Mar 19, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 61ac0b3

@cypress-app-bot
Copy link
Collaborator

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit 61ac0b3
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/65f9312dcd17b40008632f34
😎 Deploy Preview https://deploy-preview-5757--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 19, 2024 06:36
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have a linter for these things, so yah npm lowercase was accurate.

@jennifer-shehane jennifer-shehane merged commit b6181f9 into cypress-io:main Mar 19, 2024
9 checks passed
@MikeMcC399 MikeMcC399 deleted the npm-branding branch March 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants