Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cy.origin command API page #4439

Merged
merged 17 commits into from
Apr 25, 2022
Merged

Add cy.origin command API page #4439

merged 17 commits into from
Apr 25, 2022

Conversation

debrisapron
Copy link
Contributor

This draft API page is under active development & will be getting rewrites and extra content. Also, other docs updates needed for this feature (changelog, cy.session, trade-offs etc) will be made in additional PRs which will all be merged to one content/experimentalSessionAndOrigin branch, before final review & merge to master.

@vercel
Copy link

vercel bot commented Apr 14, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cypress-io/cypress-documentation/4ojCMY1B4sxUtmi7SvVvnv5SQdVZ
✅ Preview: https://cypress-documentation-git-content-add-cyorigi-d03465-cypress-io.vercel.app

@debrisapron debrisapron force-pushed the content/experimentalSessionAndOrigin branch 2 times, most recently from b760452 to b4bf81c Compare April 14, 2022 04:27
@debrisapron debrisapron force-pushed the content/add-cy.origin-api-page branch from ab33e71 to c3fc24b Compare April 14, 2022 04:30
@debrisapron
Copy link
Contributor Author

debrisapron commented Apr 14, 2022 •
edited
Loading

[OUTDATED] Page preview here: https://cypress-documentation-13jgl1zj4-cypress-io.vercel.app/api/commands/origin (with Axolo)

@flotwig flotwig mentioned this pull request Apr 18, 2022
Merged
5 tasks
jennifer-shehane
jennifer-shehane requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debrisapron This is great! It reads really well and fluidly. Good wording that is explaining to the users why they need to care about something. I added some change suggestions.

content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
content/api/commands/origin.md Outdated Show resolved Hide resolved
flotwig
flotwig suggested changes Apr 19, 2022
View reviewed changes
content/api/commands/origin.md Outdated Show resolved Hide resolved
@emilyrohrbough emilyrohrbough mentioned this pull request Apr 21, 2022
Merged
5 tasks
emilyrohrbough
emilyrohrbough requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@emilyrohrbough emilyrohrbough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The experiments section on the configuration page needs updated to reflect that experimentalSessionSupport has been replaced with experimentalSessionAndOrigin.

https://docs.cypress.io/guides/references/experiments#Configuration

@debrisapron
Copy link
Contributor Author

The experiments section on the configuration page needs updated to reflect that experimentalSessionSupport has been replaced with experimentalSessionAndOrigin.

https://docs.cypress.io/guides/references/experiments#Configuration

This will be addressed in a separate PR.

@debrisapron debrisapron changed the base branch from content/experimentalSessionAndOrigin to 9.6.0-release April 22, 2022 01:40
@vercel
Copy link

vercel bot commented Apr 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cypress-documentation ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 4:26PM (UTC)

jennifer-shehane and others added 8 commits April 25, 2022 10:29
@jennifer-shehane @mschile
Update content/api/commands/origin.md
aa448c1 
Co-authored-by: Matt Schile <[email protected]>
@jennifer-shehane @chrisbreiding
Update content/api/commands/origin.md
fa061db 
Co-authored-by: Chris Breiding <[email protected]>
@jennifer-shehane @emilyrohrbough
Update content/api/commands/origin.md
46edd53 
Co-authored-by: Emily Rohrbough  <[email protected]>
@jennifer-shehane @chrisbreiding
Update content/api/commands/origin.md
d8796bc 
Co-authored-by: Chris Breiding <[email protected]>
@jennifer-shehane @chrisbreiding
Update content/api/commands/origin.md
0a830f7 
Co-authored-by: Chris Breiding <[email protected]>
@jennifer-shehane @mschile
Update content/api/commands/origin.md
ff7620f 
Co-authored-by: Matt Schile <[email protected]>
@jennifer-shehane @AtofStryker
Update content/api/commands/origin.md
d97faf8 
Co-authored-by: Bill Glesias <[email protected]>
@jennifer-shehane @emilyrohrbough
Update content/api/commands/origin.md
8806d91 
Co-authored-by: Emily Rohrbough  <[email protected]>
@emilyrohrbough emilyrohrbough self-requested a review April 25, 2022 16:01
@jennifer-shehane jennifer-shehane self-requested a review April 25, 2022 16:06
@debrisapron debrisapron merged commit d8d17f4 into 9.6.0-release Apr 25, 2022
@debrisapron debrisapron deleted the content/add-cy.origin-api-page branch April 25, 2022 16:30
@frederikprijck frederikprijck mentioned this pull request Sep 27, 2022
Closed
@paolodm paolodm mentioned this pull request May 13, 2023
Open
@novalina26 novalina26 mentioned this pull request Nov 27, 2023
Open
@paolodm paolodm mentioned this pull request Dec 20, 2023
Open
@novalina26 novalina26 mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtofStryker AtofStryker AtofStryker left review comments

@mschile mschile mschile left review comments

@mjhenkes mjhenkes mjhenkes left review comments

@flotwig flotwig flotwig requested changes

@emilyrohrbough emilyrohrbough emilyrohrbough approved these changes

@chrisbreiding chrisbreiding chrisbreiding approved these changes

@jennifer-shehane jennifer-shehane Awaiting requested review from jennifer-shehane

Assignees
No one assigned
Labels
content: new section: api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@debrisapron @emilyrohrbough @flotwig @chrisbreiding @jennifer-shehane @mjhenkes @mschile @AtofStryker