Skip to content

Commit

Permalink
BROWSERS_IMAGE_SHORT_TAG usable for alternate versions
Browse files Browse the repository at this point in the history
  • Loading branch information
MikeMcC399 committed Nov 25, 2024
1 parent c950845 commit b0c0841
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ If you need to release alternate versions that do not qualify to be primary vers

1. Create a feature branch in the form `<cypress-version>-node-<node.js version>-publish`, for example `13.11.0-node-18.20.3-publish`, branched from the `master` branch. If you are not a member of the Cypress org, make a request via a new issue to create a feature branch.
2. Modify [factory/.env](./factory/.env) with the desired versions. Do not modify the `FACTORY_VERSION`. No new `cypress/factory` image should be published with this process.
3. Modify [factory/docker-compose.yml](./factory/docker-compose.yml) to comment out the creation of `latest` tags. Comment out the `cypress/browsers` `BROWSERS_IMAGE_SHORT_TAG` and `cypress/included` `INCLUDED_IMAGE_SHORT_TAG` to also prevent these tags from being created. This step is essential to avoid the related tags of any existing released images being moved to point to non-primary images.
3. Modify [factory/docker-compose.yml](./factory/docker-compose.yml) to comment out the creation of `latest` tags. Comment out the `cypress/included` `INCLUDED_IMAGE_SHORT_TAG` to also prevent this tag from being created. This step is essential to avoid the related tags of any existing released images being moved to point to non-primary images.
4. Modify [circle.yml](circle.yml) to push releases from the feature branch.
5. Open a PR which targets the feature branch.
6. After PR merge, check Docker Hub and the associated new image(s).
Expand Down
2 changes: 1 addition & 1 deletion factory/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ services:
EDGE_VERSION: ${EDGE_VERSION}
tags:
- ${REPO_PREFIX-}cypress/browsers:latest # comment out for release of alternate version
- ${REPO_PREFIX-}cypress/browsers:${BROWSERS_IMAGE_SHORT_TAG} # comment out for release of alternate version
- ${REPO_PREFIX-}cypress/browsers:${BROWSERS_IMAGE_SHORT_TAG}
- ${REPO_PREFIX-}cypress/browsers:${BROWSERS_IMAGE_TAG}
command: node -v

Expand Down

0 comments on commit b0c0841

Please sign in to comment.