Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explicit check against codeCoverage.expectFrontendCoverageOnly before attempting to collect backend coverage #474

Closed
wants to merge 4 commits into from
Closed

feat: add explicit check against codeCoverage.expectFrontendCoverageOnly before attempting to collect backend coverage #474

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
790cda0
feat: add explicit check against codeCoverage.expectFrontendCoverageO…
funkadelic Jun 25, 2021
2220d1c
Merge branch 'master' into master
funkadelic Jun 26, 2021
7ef61bd
Merge branch 'master' into master
funkadelic Jul 19, 2021
0dca3ff
Merge branch 'master' into master
funkadelic Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,11 @@ const registerHooks = () => {
const baseUrl = Cypress.config('baseUrl') || cy.state('window').origin
// @ts-ignore
const runningEndToEndTests = baseUrl !== Cypress.config('proxyUrl')
const expectFrontendCoverageOnly = Cypress._.get(Cypress.env('codeCoverage'), 'expectFrontendCoverageOnly', false)
const specType = Cypress._.get(Cypress.spec, 'specType', 'integration')
const isIntegrationSpec = specType === 'integration'

if (runningEndToEndTests && isIntegrationSpec) {
if (!expectFrontendCoverageOnly && runningEndToEndTests && isIntegrationSpec) {
// we can only request server-side code coverage
// if we are running end-to-end tests,
// otherwise where do we send the request?
Expand Down