Skip to content
This repository has been archived by the owner on Mar 1, 2022. It is now read-only.

For each provider, just pass token property #4

Open
bahmutov opened this issue Oct 5, 2017 · 0 comments
Open

For each provider, just pass token property #4

bahmutov opened this issue Oct 5, 2017 · 0 comments

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Oct 5, 2017

Why use custom names inside each?

Instead of:

car = bumpercar.create({
    providers: {
      travis: {
        githubToken: creds.githubToken
      }
      circle: {
        circleToken: creds.circleToken
      }
      appVeyor: {
        appVeyorToken: creds.appVeyorToken
      }
    }
  })

should be

car = bumpercar.create({
    providers: {
      travis: {
        token: creds.githubToken
      }
      circle: {
        token: creds.circleToken
      }
      appVeyor: {
        token: creds.appVeyorToken
      }
    }
  })

This would be a breaking change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant