style(cypht): scope menu toggling to not interfere with Tiki elements #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josaphatim
changed the title
josaphatim
changed the title
josaphatim
changed the title
josaphatim
changed the title
|
@josaphatim, to achieve your intended behavior, you need to add the Some of the current changes might still be interesting to keep! |
josaphatim
force-pushed
the
prefix-elements-to-not-interfere-in-intergration
branch
from
661f812
to
d970b7d
Compare
|
@jacob-js I like the proposed solution. Other changes were committed by error. It's a work in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click on menu button is having impact on Tiki menu as same html tags involved are shared in both Cypht and Tiki.