Fix: Missing text and annotationlayer imports for React-PDF #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pat721 Thank you for your support! Merged! I will release a new version with your changes. |
This was referenced Oct 23, 2023
Closed
|
Hey, this change is causing it's broken on Next.js because CSS it importing in the build..., a lot of users are facing this issue now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cyntler
The PDFRender uses PDF-React as Library. There the imports for the Text and Annotationlayer are missing. This causes
incorrect render behaviour. I added the missing imports according to the PDF-React documentation: Support for text and annotationlayer . This issue was likely cause by updating the React-PDF dependency in #88 from 5.7.2 (no text and annotationlayer support) to 7.5.0.
Before:
The text and annotationlayer were improperly rendered below the pdf canvas. This also prevented from text being directly highlightable and therefore copyable from the rendered PDF.
After:
The text and annotationlayer are correctly rendered on top of the pdf canvas. The text is highlightable and copyable.
