Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to run tests in any directory, not only the current one #24

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

maelle
Copy link
Member

@maelle maelle commented Apr 20, 2023

Seems useful to have before a CRAN release 😸

@maelle maelle requested a review from krlmlr April 20, 2023 08:48
@maelle maelle marked this pull request as draft April 20, 2023 08:51
@maelle maelle removed the request for review from krlmlr April 20, 2023 08:55
@maelle
Copy link
Member Author

maelle commented Apr 20, 2023

Now I understand why you made it so @krlmlr, it's somehow very hard to change without breaking the tests?! they still pass from devtools::test() but not in R CMD check.

@maelle maelle marked this pull request as ready for review April 20, 2023 10:59
@maelle
Copy link
Member Author

maelle commented Apr 20, 2023

in the end, the test setup was the culprit 🙃

@maelle
Copy link
Member Author

maelle commented Apr 20, 2023

From looking in testthat tests quickly, it seems that instead of callr I could use a silent reporter but it somehow is less clear for me? Or did I get too invested in the current "weird" setup?!

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #24 (9920bcf) into main (34b8ba7) will increase coverage by 0.65%.
The diff coverage is 100.00%.

❗ Current head 9920bcf differs from pull request most recent head 6169e5d. Consider uploading reports for the commit 6169e5d to get more accurate results

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   77.50%   78.15%   +0.65%     
==========================================
  Files           3        3              
  Lines         120      119       -1     
==========================================
  Hits           93       93              
+ Misses         27       26       -1     
Impacted Files Coverage Δ
R/lazytest_local.R 98.21% <100.00%> (+1.72%) ⬆️

@maelle maelle requested a review from krlmlr May 5, 2023 07:00
@krlmlr
Copy link
Contributor

krlmlr commented May 15, 2023

No strong opinion, we can also leave the current behavior for the CRAN release.

@maelle
Copy link
Member Author

maelle commented May 15, 2023

But should this PR be merged?

@krlmlr
Copy link
Contributor

krlmlr commented May 19, 2023

The Windows tests keep failing.

I'm seeing similar failures with dev pkgload, and other failures with dev usethis: https://github.com/cynkra/lazytest/actions/runs/5019480976/jobs/9000043037 . These should be fixed before release, with or without the path feature. Can you please take a look?

@maelle
Copy link
Member Author

maelle commented May 19, 2023

I can't reproduce the pkgload issue, might have to explore next week.

@maelle
Copy link
Member Author

maelle commented Jun 5, 2023

I get a failure locally 🎉

@maelle
Copy link
Member Author

maelle commented Jun 5, 2023

still no luck exploring the pkgload failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants