-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make it possible to run tests in any directory, not only the current one #24
base: main
Are you sure you want to change the base?
Conversation
Now I understand why you made it so @krlmlr, it's somehow very hard to change without breaking the tests?! they still pass from |
in the end, the test setup was the culprit 🙃 |
From looking in testthat tests quickly, it seems that instead of callr I could use a silent reporter but it somehow is less clear for me? Or did I get too invested in the current "weird" setup?! |
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 77.50% 78.15% +0.65%
==========================================
Files 3 3
Lines 120 119 -1
==========================================
Hits 93 93
+ Misses 27 26 -1
|
No strong opinion, we can also leave the current behavior for the CRAN release. |
But should this PR be merged? |
The Windows tests keep failing. I'm seeing similar failures with dev pkgload, and other failures with dev usethis: https://github.com/cynkra/lazytest/actions/runs/5019480976/jobs/9000043037 . These should be fixed before release, with or without the path feature. Can you please take a look? |
I can't reproduce the pkgload issue, might have to explore next week. |
I get a failure locally 🎉 |
still no luck exploring the pkgload failure. |
Seems useful to have before a CRAN release 😸