Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc set: log warning when no outputs specified and task has no required outputs #6505

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Nov 29, 2024

R1 = a? => b
$ cylc set workflow//1/a

does nothing and currently produces no warning.

This change makes it log a warning.

https://cylc.discourse.group/t/cylc-set-for-a-task-with-multiple-outputs-doesnt-seem-to-do-anything/1074

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • No changelog entry needed as minor
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added small could be better Not exactly a bug, but not ideal. labels Nov 29, 2024
@MetRonnie MetRonnie added this to the 8.4.0 milestone Nov 29, 2024
@MetRonnie MetRonnie self-assigned this Nov 29, 2024
@hjoliver hjoliver self-requested a review December 2, 2024 00:20
@MetRonnie MetRonnie marked this pull request as draft December 2, 2024 11:00
@MetRonnie
Copy link
Member Author

MetRonnie commented Dec 2, 2024

I realised there was a slight mistake and the test was not quite what I wanted.

@oliver-sanders Why, for task a in

R1 = """
    a? => b
    a:x
"""

is the auto-generated completion statement (x and succeeded) or failed? This is making x optional even though it is not optional in the graph.

Shouldn't it be x and (succeeded or failed)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants