Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcast: reject truncated cycle points #6414

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Oct 15, 2024

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Oct 15, 2024
@oliver-sanders oliver-sanders added this to the 8.3.6 milestone Oct 15, 2024
@oliver-sanders oliver-sanders self-assigned this Oct 15, 2024
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. Have tried it and it appears to fix the bug in question.

Presumably waiting for release stuff to finish before adding a changelog?

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Oct 16, 2024

Presumably waiting for release stuff to finish before adding a changelog?

Waiting for a PR number (couldn't be bothered to guess).

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also prevents traceback when doing e.g. cylc hold <future-task> using a truncated cycle

@MetRonnie MetRonnie merged commit 9b4bac3 into cylc:8.3.x Oct 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants