Feat.lint obsolete vars #5879
Merged
Feat.lint obsolete vars #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
feat.lint-obsolete-vars
branch
3 times, most recently
from
edf6c98
to
5cbb2cf
Compare
wxtim
force-pushed
the
feat.lint-obsolete-vars
branch
from
5cbb2cf
to
1e353ad
Compare
MetRonnie
reviewed
Dec 14, 2023
cylc/flow/scripts/lint.py
Outdated
Comment on lines
115
to
116
| 'task_url': 'URL from task metadata', | ||
| 'workflow_url': 'workflow_URL from workflow metadata', |
There was a problem hiding this comment.
What doe these mean, "from task/workflow metadata"?
There was a problem hiding this comment.
You can set these items in
# flow.cylc
[meta]
workflow_url = "www.hat.ever"
[runtime]
[[task]]
[[[meta]]]
task = "some://url"
And they will be available. If you don't, they won't.
There was a problem hiding this comment.
Ah right. I'm not sure this is clear and it might be good to be able to link to an example in the docs. However the closest I could find is this section in https://cylc.github.io/cylc-doc/latest/html/user-guide/writing-workflows/runtime.html#task-event-template-variables
Unfortunately the specific item is not linkable, only the section heading quite far up
There was a problem hiding this comment.
I agree. I'll have a think about how this might work.
There was a problem hiding this comment.
@MetRonnie - Have another look, I should think that it's better now.
Co-authored-by: Ronnie Dutta <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
MetRonnie
approved these changes
Dec 14, 2023
MetRonnie
approved these changes
Dec 14, 2023
Tests earning their keep. Hopefully Will pass now. |
markgrahamdawson
approved these changes
Dec 20, 2023
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Jan 9, 2024
* upstream/master: (350 commits) Apply suggestions from code review [skip ci] Added missing union type import (cylc#5906) set CYLC_DEBUG env var when set-verbosity DEBUG (cylc#5854) coverage: exclude report-timings and set 90% as the lower limit lint: Warn users that `CYLC_VERSION={{CYLC_VERSION}}` is deprecated (cylc#5890) Add a new entry_point for xtriggers (cylc#5831) Update copyright year Tests: fix cached datetime arithmetic contamination between tests using different calendar modes Replace cyclers functional reftests with integration reftests Simplify integration reftest Replace pre-initial functional reftests with integration reftests Integration tests: add a simpler reftest fixture auto update syntax files id: catch traceback in ID parsing actions: downgrade macos runners to macos 11 (cylc#5892) Feat.lint obsolete vars (cylc#5879) dump: restrict window to n=0 (cylc#5600) Add chained offset logic for FCP (cylc#5885) Test.example replace a reftest (cylc#5860) GH Actions artifact name fixes ...
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Jan 11, 2024
* upstream/master: (81 commits) Apply suggestions from code review [skip ci] Added missing union type import (cylc#5906) coverage: exclude report-timings and set 90% as the lower limit lint: Warn users that `CYLC_VERSION={{CYLC_VERSION}}` is deprecated (cylc#5890) Add a new entry_point for xtriggers (cylc#5831) Tests: fix cached datetime arithmetic contamination between tests using different calendar modes Replace cyclers functional reftests with integration reftests Simplify integration reftest Replace pre-initial functional reftests with integration reftests Integration tests: add a simpler reftest fixture auto update syntax files Feat.lint obsolete vars (cylc#5879) dump: restrict window to n=0 (cylc#5600) Test.example replace a reftest (cylc#5860) GH Actions artifact name fixes Bump actions/upload-artifact from 3 to 4 Bump actions/download-artifact from 3 to 4 tests/i: update tui screenshot Update .github/workflows/test_fast.yml actions: add non-utc job to fast tests ...
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Jan 12, 2024
* upstream/master: (81 commits) Apply suggestions from code review [skip ci] Added missing union type import (cylc#5906) coverage: exclude report-timings and set 90% as the lower limit lint: Warn users that `CYLC_VERSION={{CYLC_VERSION}}` is deprecated (cylc#5890) Add a new entry_point for xtriggers (cylc#5831) Tests: fix cached datetime arithmetic contamination between tests using different calendar modes Replace cyclers functional reftests with integration reftests Simplify integration reftest Replace pre-initial functional reftests with integration reftests Integration tests: add a simpler reftest fixture auto update syntax files Feat.lint obsolete vars (cylc#5879) dump: restrict window to n=0 (cylc#5600) Test.example replace a reftest (cylc#5860) GH Actions artifact name fixes Bump actions/upload-artifact from 3 to 4 Bump actions/download-artifact from 3 to 4 tests/i: update tui screenshot Update .github/workflows/test_fast.yml actions: add non-utc job to fast tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another item from Oliver's wishlist at #4917:
Search for deprecated items from this list
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.