cat-log: support workflow files #5453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2023
oliver-sanders
commented
Apr 6, 2023
oliver-sanders
commented
Apr 6, 2023
oliver-sanders
force-pushed
the
cat-log-workflow-file-option
branch
2 times, most recently
from
8c09b9a
to
0a41a01
Compare
oliver-sanders
commented
Apr 6, 2023
oliver-sanders
commented
Apr 6, 2023
oliver-sanders
force-pushed
the
cat-log-workflow-file-option
branch
from
0a41a01
to
d97c275
Compare
|
Rebasing onto 8.1.x to allow this work to be released before the Vue3 upgrade. For safekeeping the 8.1.x branch can be found here: https://github.com/oliver-sanders/cylc-flow/pull/new/cat-log-workflow-file-option-8.2 |
oliver-sanders
force-pushed
the
cat-log-workflow-file-option
branch
from
d97c275
to
45861c5
Compare
|
(re-opened to kick-ci into action) |
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this pull request
Apr 18, 2023
* cylc#439 requires cylc/cylc-flow#5453 added in cylc-flow 8.1.3
oliver-sanders
commented
Apr 18, 2023
oliver-sanders
commented
Apr 18, 2023
8 tasks
hjoliver
approved these changes
Apr 19, 2023
wxtim
reviewed
Apr 19, 2023
|
I kicked the functional tests- I have the two failing |
wxtim
reviewed
Apr 19, 2023
* Update cat log to request specific workflow log file with -f option
oliver-sanders
force-pushed
the
cat-log-workflow-file-option
branch
3 times, most recently
from
cca4417
to
dd8cfff
Compare
* Support specifying the job submit number in the ID. * Support specifying the most recent workflow log file via a one letter filename as with job logs. * Add --prepend-path option which print the host:filepath before cat or tail operations. This is used by the UI to display the host:path where the log file is located.
oliver-sanders
force-pushed
the
cat-log-workflow-file-option
branch
from
dd8cfff
to
e01ce1b
Compare
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this pull request
Apr 20, 2023
* cylc#439 requires cylc/cylc-flow#5453 added in cylc-flow 8.1.3
wxtim
approved these changes
Apr 21, 2023
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install/andconfig/logs.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.