Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict --set & --set-file options in cylc vr #5297

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 12, 2023

This PR documents the bug as well as fixing it. There is no related issue. Follow-up to #5229

Synopsis

--set and --set-file were included by mistake in cylc vr because I copied the general form of VR from cylc vip where it makes sense. Reinstall doesn't use these CLI variables so they won't change the workflow. This is potentially misleading to users.

Code to try

#!jinja2
# Cylc Workflow
[scheduler]
    allow implicit tasks = ture
[scheduling]
    [[graph]]
        {{CYCLE}}= foo => bar => baz

then,

On the command line

cylc vip --set 'CYCLE="PT1H"'
...

# Does not change the running workflow!
cylc vr --set 'CYCLE="PT2H"' 

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • No tests, change is specification rather than tests.
  • No CHANGES.md entry - this effectively fixes a recently added PR before relase.
  • NO Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.

@wxtim wxtim requested a review from MetRonnie January 12, 2023 10:29
@wxtim wxtim self-assigned this Jan 12, 2023
@wxtim wxtim added this to the cylc-8.1.0 milestone Jan 12, 2023
…lidate reinstall should stop, because these options have no effect
@wxtim wxtim changed the title Removed --set & --set-file options from cylc vr Restrict --set & --set-file options in cylc vr Jan 12, 2023
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

cylc/flow/scripts/validate_reinstall.py Outdated Show resolved Hide resolved
cylc/flow/scripts/validate_reinstall.py Outdated Show resolved Hide resolved
@wxtim wxtim requested a review from MetRonnie January 12, 2023 14:19
Co-authored-by: Oliver Sanders <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
@MetRonnie MetRonnie merged commit f439cfe into cylc:master Jan 12, 2023
@wxtim wxtim deleted the no_cylc_tvars_for_vr branch January 12, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants