Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable broadcast from UI Edit-Runtime form #5232

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Enable broadcast from UI Edit-Runtime form #5232

merged 3 commits into from
Nov 21, 2022

Conversation

MetRonnie
Copy link
Member

Follow-up to #5138, use custom object type RuntimeSetting instead of GenericScalar in schema

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • No changelog entry needed
  • No docs needed

@MetRonnie MetRonnie added this to the cylc-8.1.0 milestone Nov 18, 2022
@MetRonnie MetRonnie self-assigned this Nov 18, 2022
@MetRonnie
Tidy schema
fa21b27
@MetRonnie
Enable broadcast from UI Edit-Runtime form
7d7b5dc 
Use custom schema type RuntimeSetting instead of GenericScalar
@MetRonnie MetRonnie mentioned this pull request Nov 18, 2022
Closed
6 tasks
@MetRonnie MetRonnie marked this pull request as ready for review November 18, 2022 16:57
dwsutherland
dwsutherland approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

oliver-sanders
oliver-sanders approved these changes Nov 21, 2022
View reviewed changes
cylc/flow/network/schema.py Outdated Show resolved Hide resolved
cylc/flow/network/schema.py Outdated Show resolved Hide resolved
@MetRonnie
Copy link
Member Author

(Fast test failure just due to codecov upload failure again)

hjoliver
hjoliver approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(kicked tests, passed)

@hjoliver hjoliver merged commit e9fc2b5 into cylc:master Nov 21, 2022
@MetRonnie MetRonnie deleted the edit-runtime branch November 22, 2022 09:53
@MetRonnie MetRonnie added the schema change Change to the Cylc GraphQL schema label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@dwsutherland dwsutherland dwsutherland approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
schema change Change to the Cylc GraphQL schema
Projects
None yet
Milestone
cylc-8.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MetRonnie @hjoliver @dwsutherland @oliver-sanders