Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consolidation tutorial #5199

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Fix consolidation tutorial #5199

merged 2 commits into from
Oct 25, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Oct 17, 2022 •
edited
Loading

Closes #5198

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests not needed
  • CHANGES.md entry included if this is a change that can affect users
  • No docs change needed
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

@MetRonnie MetRonnie added this to the cylc-8.0.4 milestone Oct 17, 2022
@MetRonnie MetRonnie requested a review from wxtim October 17, 2022 12:17
@MetRonnie MetRonnie self-assigned this Oct 17, 2022
@MetRonnie MetRonnie linked an issue Oct 17, 2022 that may be closed by this pull request
Two minor bugs in consolidation tutorial #5198
Closed
@MetRonnie MetRonnie marked this pull request as ready for review October 17, 2022 14:59
wxtim
wxtim approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted.

@wxtim wxtim merged commit 1939932 into cylc:8.0.x Oct 25, 2022
@MetRonnie MetRonnie deleted the tutorial branch October 25, 2022 10:54
wxtim added a commit to wxtim/cylc that referenced this pull request Oct 25, 2022
@wxtim
Merge remote-tracking branch 'upstream/8.0.x' into 8.0.x-deconflict
41ab911 
* upstream/8.0.x:
  Fix consolidation tutorial (cylc#5199)
  GH Actions Codecov upload: try using token arg (cylc#5179)
wxtim added a commit to wxtim/cylc that referenced this pull request Oct 31, 2022
@wxtim
Merge branch '20221010T0945--HEAD--get_template_vars_from_running_wf'…
9040953 
… of github.com:wxtim/cylc into 20221010T0945--HEAD--get_template_vars_from_running_wf

* '20221010T0945--HEAD--get_template_vars_from_running_wf' of github.com:wxtim/cylc: (51 commits)
  make revalidate automatic if workflow has changed at source
  play: --upgrade and --downgrade options
  Fix consolidation tutorial (cylc#5199)
  8.0.x -> master (cylc#5206)
  GH Actions Codecov upload: try using token arg (cylc#5179)
  Update CHANGES.md [skip ci]
  Add type hints.
  Switch to better monkeypatching approach. [skip ci]
  Add explanatory comments. [skip ci]
  Update CHANGES.md [skip ci]
  play: check Cylc version on restart
  Use a context manager in new test.
  Update change log.
  Extend new test coverage.
  install: scan only target workflow
  Apply suggestions from code review
  Add integration test.
  Scan workflow name during install.
  fix an error handling bug in Cylc Scan
  update PR template (cylc#5202)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

Assignees

@MetRonnie MetRonnie

Labels
bug Something is wrong :( small tutorial-workflows
Projects
None yet
Milestone
cylc-8.0.4
Development

Successfully merging this pull request may close these issues.

Two minor bugs in consolidation tutorial
2 participants
@MetRonnie @wxtim