Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restart number bug #5037

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Fix restart number bug #5037

merged 3 commits into from
Aug 4, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Aug 2, 2022 •
edited
Loading

Closes #4918

A bug was causing the restart number to be wiped from the workflow_params table in the DB on reload.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included
  • Appropriate change log entry included.
  • No documentation update required.
  • PRs raised to both master (Merge 8.0.x into master #5042) and the relevant bugfix branch.

@MetRonnie MetRonnie added bug Something is wrong :( small labels Aug 2, 2022
@MetRonnie MetRonnie added this to the cylc-8.0.1 milestone Aug 2, 2022
@MetRonnie MetRonnie self-assigned this Aug 2, 2022
@MetRonnie MetRonnie deleted the branch cylc:8.0.x August 3, 2022 11:58
@MetRonnie MetRonnie closed this Aug 3, 2022
@MetRonnie MetRonnie reopened this Aug 3, 2022
oliver-sanders
oliver-sanders approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test.

datamel
datamel approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out and tested, thanks @MetRonnie

@datamel datamel merged commit fa5c107 into cylc:8.0.x Aug 4, 2022
@MetRonnie MetRonnie deleted the restart-num-bug branch August 4, 2022 08:49
@MetRonnie MetRonnie mentioned this pull request Aug 4, 2022
Merged
@MetRonnie MetRonnie linked an issue Aug 8, 2022 that may be closed by this pull request
Start number reset after a reload #4918
Closed
oliver-sanders pushed a commit to oliver-sanders/cylc-flow that referenced this pull request Aug 15, 2022
@MetRonnie @oliver-sanders
Fix restart number bug (cylc#5037)
72c5968 
* Create integration test for restart number

* Fix restart num bug

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamel datamel datamel approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@MetRonnie MetRonnie

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
cylc-8.0.1
Development

Successfully merging this pull request may close these issues.

Start number reset after a reload
4 participants
@MetRonnie @hjoliver @oliver-sanders @datamel