Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore json parse error if jsonType.ignoreError is positive #409

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

cyjake
Copy link
Owner

@cyjake cyjake commented Nov 9, 2023

closes #407

Copy link
Collaborator

@SmartOrange SmartOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (834c80b) 96.66% compared to head (ce51f9d) 96.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          45       45           
  Lines        3625     3627    +2     
  Branches       71       72    +1     
=======================================
+ Hits         3504     3506    +2     
  Misses        106      106           
  Partials       15       15           
Files Coverage Δ
src/data_types.ts 96.66% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmyDaddy JimmyDaddy merged commit 4c76447 into master Nov 9, 2023
6 checks passed
@JimmyDaddy JimmyDaddy deleted the feat-ignore-json-error branch November 9, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON cast/uncast console.error 存在导致日志文件过大的问题。希望可以有办法规避
3 participants