Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select everything when forming subspell #382

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: select everything when forming subspell #382

merged 1 commit into from
Mar 24, 2023

Conversation

cyjake
Copy link
Owner

@cyjake cyjake commented Mar 24, 2023

otherwise the columns might be quolified unnecessarily, or worse, insufficient for further joining

@cyjake
fix: select everything when forming subspell
0392a9f 
otherwise the columns might be quolified unnecessarily, or worse, insufficient for further joining
cyjake
cyjake commented Mar 24, 2023
View reviewed changes
test/integration/suite/sharding.test.ts
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个看上去是 false alarm，先回滚掉了

cyjake
cyjake commented Mar 24, 2023
View reviewed changes
docs/zh/querying.md

```sql
SELECT * FROM (SELECT * FROM posts LIMIT 1) AS posts LEFT JOIN comments ON comments.post_id = posts.id LIMIT 10
```
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加了一点文档说明，这个改动价值蛮大的

@JimmyDaddy JimmyDaddy merged commit fc88a06 into master Mar 24, 2023
@JimmyDaddy JimmyDaddy deleted the fix-subspell-select branch March 24, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmyDaddy JimmyDaddy JimmyDaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyjake @JimmyDaddy