fix: ts type definitions #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JimmyDaddy
commented
Sep 26, 2022
JimmyDaddy
commented
- attributeWas
- QueryOptions.transaction support null
- sequelize instance.update
vagusX
reviewed
Sep 26, 2022
| @@ -21,12 +21,17 @@ interface BaseSequelizeConditions<T extends typeof SequelizeBone> extends QueryO | |||
| where?: WhereConditions<T>; | |||
| order?: OrderOptions<T>; | |||
| limit?: number; | |||
| attributes?: string | Raw | Array<[keyof Extract<InstanceType<T>, Literal>] | string | Raw> | [keyof Extract<InstanceType<T>, Literal>]; | |||
| attributes?: string | Raw | Array<[keyof Extract<CommonValues<InstanceType<T>>, Literal>] | string | Raw> | [keyof Extract<CommonValues<InstanceType<T>>, Literal>]; | |||
There was a problem hiding this comment.
是否考虑 sequelize 这个文件用 ts 写呀
There was a problem hiding this comment.
除非 bone 也用 ts 写，单独改这个用处不大，类型提示反而更难处理
cyjake
reviewed
Sep 26, 2022
| @@ -249,7 +249,7 @@ export class AbstractBone { | |||
| * @example | |||
| * bone.attributeWas('foo') // => 1 | |||
| */ | |||
| attributeWas(name: string): Literal; | |||
| attributeWas<T, Key extends keyof Values<T>>(this: T, key: Key): T[Key]; | |||
JimmyDaddy
force-pushed
the
fix/ts_type_definitions_1
branch
from
1d61528 to
d7e7bba
Compare
cyjake
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.