Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: order by alias should not throw #255

Merged
merged 1 commit into from
Jan 6, 2022
Merged

fix: order by alias should not throw #255

merged 1 commit into from
Jan 6, 2022

Conversation

cyjake
Copy link
Owner

@cyjake cyjake commented Jan 5, 2022 

     TypeError: Cannot read property 'length' of undefined
      at checkQualifier (src/drivers/abstract/spellbook.js:224:39)
      at walkExpr (src/expr.js:415:3)
      at Object.formatSelectWithJoin (src/drivers/abstract/spellbook.js:229:37)
      at Object.formatSelect (src/drivers/abstract/spellbook.js:292:12)
      at Object.format (src/drivers/abstract/spellbook.js:572:21)
      at MysqlDriver.format (src/drivers/mysql/index.js:109:22)
      at Spell.ignite (src/spell.js:428:42)
      at Spell.then (src/spell.js:447:17)

@JimmyDaddy JimmyDaddy merged commit d8deacb into master Jan 6, 2022
@cyjake cyjake deleted the fix-order-by-alias branch January 6, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmyDaddy JimmyDaddy JimmyDaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyjake @JimmyDaddy