Do not emit an empty module export in the index if no module is required #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #337
We might not want a module but still want an index, e.g.:
In such a case, we'd get something like:
Solution
Guard the export in the template. Be sure to not break things by writing tests for the exports in
index.ts
for both cases - whenevermodule
is on or off.Testing done
Verified the output no longer contains such an export in that case.
Verified the existing exports are not regressed.
Compared the test output before and after the fix:
(The diff in
path-6-get.ts
seems unrelated, probably due to non-determinism)