Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #279 Exclude API definitions with by matching the API path #302

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

pillsilly
Copy link
Contributor

@pillsilly pillsilly commented Nov 16, 2023

A draft should be able to fix #279
Please kindly check if it looks OK to you @luisfpg

If yes I will continue to add content in README.md and maybe some more refinement(like allowing user to inject their own filter logic )

Thank you.

@jurgenf
Copy link
Contributor

jurgenf commented Nov 19, 2023

Hi @pillsilly, did you tag me by mistake? I have not participated in this issue and I am not a maintainer of this repository. If you want my feedback I can certainly look at your PR but I can't help you with getting it merged.

@pillsilly
Copy link
Contributor Author

Hi @pillsilly, did you tag me by mistake? I have not participated in this issue and I am not a maintainer of this repository. If you want my feedback I can certainly look at your PR but I can't help you with getting it merged.

you're right and thank you very much for reminding

@pillsilly
Copy link
Contributor Author

@luisfpg would you kindly help to check this PR.

@luisfpg luisfpg merged commit 24eb453 into cyclosproject:master Sep 6, 2024
1 check passed
@luisfpg
Copy link
Contributor

luisfpg commented Sep 6, 2024

Sorry, I'm having almost no time to work on this project.
Only today I managed to review and merge it.

@luisfpg luisfpg added the enhancement New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Exclude API definitions with a [1]more agile way in [2]earlier phase
3 participants