-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 feat: adds ReplicaSet
in Deployments
#656
base: main
Are you sure you want to change the base?
🚀 feat: adds ReplicaSet
in Deployments
#656
Conversation
@quest-bot loot #147 |
Quest PR submitted!@naineel1209, you are attempting to solve the issue and loot this Quest. Will you be successful? Questions? Check out the docs. |
Hey @petar-cvit, could you take a look at this and suggest any changes, if any? |
@naineel1209, thanks for the PR. However, I wouldn't have a separate table for replicasets, because Kubernetes will by retain the last 10 replicasets of a deployment Can we just add a progress bar to the existing pods table that would indicate how many pods are created from each replicaset. For example, if the rollout is in progress and 2 pods are managed from the old replicaset, and 3 are managed from the new one, then 2/5 of the progress bar would be blue (for old pods) and 3/5 is green |
…deployments' into feat/replicaset-in-deployments
Hi @petar-cvit , I’ve updated the Currently, I’m identifying the active |
@naineel1209 Looks awesome! You can actually find the latest replica in the I would prefer we infer it from here, not to call the k8s API once more to not bloat the endpoint. From the UI standpoint, I would remove the numbers on the right since those are not accurate in some cases |
Hi @petar-cvit, As per the suggestions, In the BE, I've added a new field, Screenshots |
@naineel1209 at first, it looked good, but when I restarted a deployment that specified 4 pods, and during rollout, there were six pods (2 from the new replicaset and four from the old one), the progress bar said 3 total, which doesn't match. Can we make the desired number of replicas in deployment the total, and the green part would tell you how many replicas from the latest replicaset are healthy. If the pods of the new replicaset are unhealthy, they will still show blue. Also, I would suggest that we don't query for replicasets separately but that we get it from the existing pods. Each pod will have a reference to its replicaset, so we don't have to ask K8s API for it. From there, you can just calculate (number of healthy pods) / (number of desired replicas in the deployment) |
…t/replicaset-in-deployments
Hey @petar-cvit, could you please check out the blocking bug details on Discord? I've got a bug blocking the PR. |
@naineel1209 thanks for reporting it! We can solve it in a separate PR, and you can ignore it in this PR. If you render data based on the deployment state, we can just fix this bug in a separate PR. |
Hi @petar-cvit, this PR is ready for review. |
hi @petar-cvit, any updates on this one? |
closes #147
📑 Description
[BE]
[FE]
ReplicaSet
in green and all the other pods from non-activeReplicaSet
in blue✅ Checks
ℹ Additional context