Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: AWS 'launch_configuration', 'launch_template' and 'autoscaling_group' resources #68

Merged
merged 4 commits into from
Dec 3, 2019

Conversation

talset
Copy link
Member

@talset talset commented Nov 26, 2019

LaunchConfiguration is now supported on cycloid-raws.
LaunchTemplate is now supported on cycloid-raws.
AutoscalingGroup is now supported on cycloid-raws.

import.go: All read error is now ignored (continue) and logged.

LaunchConfiguration is now supported on cycloid-raws.
LaunchTemplate is now supported on cycloid-raws.
AutoscalingGroup is now supported on cycloid-raws.

import.go: All read error is now ignored (continue) and logged.
@talset talset added Status: Need review Type: Enhancement Provide a new feature or improve an existing one labels Nov 26, 2019
@xescugc xescugc changed the title Fl asg Added: AWS 'launch_configuration', 'launch_template' and 'autoscaling_group' resources Nov 27, 2019
Copy link
Member

@xescugc xescugc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the Changlog too.

This PR is blocked for cycloidio/raws#52

provider/import.go Outdated Show resolved Hide resolved
provider/import.go Show resolved Hide resolved
provider/import.go Outdated Show resolved Hide resolved
provider/import.go Outdated Show resolved Hide resolved
Generate resourcetype_enumer regarding new types

 * LaunchConfiguration
 * LaunchTemplate
 * AutoscalingGroup
@talset talset force-pushed the fl-asg branch 2 times, most recently from 8c50835 to 8698e3a Compare November 29, 2019 11:29
Since we continue on importing error, HCL and State are skipped for
filtered/error resources.
Copy link
Member

@xescugc xescugc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talset talset merged commit d360034 into master Dec 3, 2019
@talset talset deleted the fl-asg branch December 3, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Provide a new feature or improve an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants