google: intermediate configuration for load balancing #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
added
Status: Need review
Provider: GCP
tormath1
changed the title
tormath1
force-pushed
the
mt-lb-front
branch
2 times, most recently
from
2778349 to
9b84c4e
Compare
xescugc
requested changes
Dec 3, 2019
tormath1
force-pushed
the
mt-google-http-lb
branch
from
da312e0 to
2503180
Compare
tormath1
force-pushed
the
mt-lb-front
branch
2 times, most recently
from
e9fdf83 to
56a5fb7
Compare
|
@xescugc I rewrite the template to add more flexibility. Now, we are able to generate all the resources added in this PR :) ready for review ! |
xlr-8
reviewed
Dec 9, 2019
|
LGTM, RS when @xlr-8 says it. |
xlr-8
approved these changes
Dec 10, 2019
since we can have different service names and functions name depending on the Google SDK resource name, we need to be able to customize this. If the Google SDK resource is TargetHttpProxy, the service name will be TargetHttpProxies since the function name will be ListTargetHTTPProxies
in this commit, we added a few new components: * URLMap * TargetHTTPProxy * TargetHTTPSProxy * SSLCertificate
tormath1
force-pushed
the
mt-lb-front
branch
from
de79f82 to
a9b0a8b
Compare
This was referenced Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Following google documentation:
HTTP(S) load balancer has 3 parts:
Backend configuration (#64 )
A backend service directs incoming traffic to an instance group. You can also use a storage bucket to serve content.
For now, I just implemented instance_group + backend_service + health_check components.
Host and path rules (this PR)
Host and path rules determine how your traffic will be directed. If you don't specify any rules, traffic will be sent to the default backend service.
target_http(s)_proxy, url_map and ssl_certificate (for https)
Frontend configuration
Your IP address, protocol and port. This is the IP to which your client requests will come in to.
More information here