azurerm: add virtual desktops resources #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can now pass the type and the name of the extra args
tormath1
added
Status: Need review
Status: In progress
and removed
Status: Need review
labels
this one is a bit harder than the others. You need to first pull the workflows, then for each worflow you request the "runs". Finally for each run, you request the actions. Since TF ARM only supports for now "custom" / "http" actions, I decided to stay with "custom" which includes "http" too
this resource requires a dedicated reader method because it does not follow the usual pattern of other ARM resources
tormath1
force-pushed
the
mt-add-azure-resources
branch
from
7cb4d29 to
728d25d
Compare
tormath1
force-pushed
the
mt-add-azure-resources
branch
from
519c3b1 to
f82d333
Compare
|
Ready for review ! |
xescugc
reviewed
Nov 17, 2020
|
@xescugc done for the changelog :) |
tormath1
force-pushed
the
mt-add-azure-resources
branch
from
ce92bcf to
f938f33
Compare
xescugc
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add some AzureRM resources for WVD. In complement of the resources, I modified the AzureRM generation parts:
ExtraArgsto handle different types of args (onlystringwas supported). First; I tried with amap[string]stringbut it's not deterministicAPIVersionto supportpreviewmodetfdocsbumped to the latest version to support VD resourcesAdded resources: