provider: filter on tags and tag

Some resources doesn't have tags attribute but tag.
Tag can't be verified with the same logic.

Implement the Tag attribut check logic

linked to #223

provider/resource.go

@@ -274,9 +274,18 @@ func (r *resource) Read(f *filter.Filter) error {
 	// so we have to do it manually
 	// it's not all of them though
 	for _, t := range f.Tags {
-		if v, ok := r.data.GetOk(fmt.Sprintf("%s.%s", r.Provider().TagKey(), t.Name)); !ok || v.(string) != t.Value {
-			return errors.WithStack(errcode.ErrProviderResourceDoNotMatchTag)
+		// Default match key
+		if v, ok := r.data.GetOk(fmt.Sprintf("%s.%s", r.Provider().TagKey(), t.Name)); ok && v.(string) == t.Value {
+			continue
 		}
+
+		// Check if the filter tag match any other tags found
+		// https://github.com/cycloidio/terracognita/issues/223
+		if v, ok := tag.GetOtherTags(r.Provider().String(), r.data, t); ok && v == t.Value {
+			continue
+		}
+
+		return errors.WithStack(errcode.ErrProviderResourceDoNotMatchTag)
 	}
 
 	// Filter out autogenerated resources from AWS

tag/tag.go

@@ -100,3 +100,33 @@ func isValidResourceName(name string) bool {
 func forceResourceName(name string) string {
 	return invalidNameRegexp.ReplaceAllString(name, "_")
 }
+
+func GetOtherTags(provider string, srd *schema.ResourceData, filterTag Tag) (string, bool) {
+	// keep the same logic as r.data.GetOk
+	otherTagsMap := make(map[string]string)
+
+	// Special Tag attribute
+	if provider == "aws" {
+		// Some resource like aws_autoscaling_group do not have tags map but tag schema.Set
+		// https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#tag
+		v, _ := srd.GetOk("tag")
+		// Get Set to List tag
+		tag, okset := v.(*schema.Set)
+		if okset {
+			// convert list to map
+			for _, i := range tag.List() {
+				// Cast to get tag key and value
+				m, okmap := i.(map[string]interface{})
+				if okmap {
+					otherTagsMap[m["key"].(string)] = m["value"].(string)
+				}
+			}
+		}
+	}
+
+	if val, ok := otherTagsMap[filterTag.Name]; ok {
+		return val, true
+	}
+
+	return "", false
+}