Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement necoperf-cli #8

Merged
merged 13 commits into from
Oct 20, 2023
Merged

Implement necoperf-cli #8

merged 13 commits into from
Oct 20, 2023

Conversation

zeroalphat
Copy link
Contributor

No description provided.

@zeroalphat zeroalphat self-assigned this Oct 2, 2023
@zeroalphat zeroalphat force-pushed the add-necoperf-cli branch 3 times, most recently from 967ce8a to 8adeb65 Compare October 4, 2023 06:03
@zeroalphat zeroalphat marked this pull request as ready for review October 4, 2023 06:05
@zeroalphat zeroalphat requested a review from zoetrope October 4, 2023 06:06
@morimoto-cybozu
Copy link
Contributor

@zeroalphat
Please add docs/necoperf-cli.md to show the usage of the necoperf-cli command.

morimoto-cybozu
morimoto-cybozu requested changes Oct 16, 2023
View reviewed changes
cmd/necoperf-cli/cmd/profile.go Outdated Show resolved Hide resolved
cmd/necoperf-cli/cmd/profile.go Outdated Show resolved Hide resolved
cmd/necoperf-cli/cmd/profile.go Outdated Show resolved Hide resolved
internal/client/client.go Outdated Show resolved Hide resolved
internal/resource/discovery.go Outdated Show resolved Hide resolved
internal/resource/discovery.go Outdated Show resolved Hide resolved
umezawatakeshi
umezawatakeshi previously approved these changes Oct 18, 2023
View reviewed changes
@zeroalphat
Copy link
Contributor Author

I made an additional correction because the implementation had the possibility of accessing nil objects.
58def59

umezawatakeshi
umezawatakeshi previously approved these changes Oct 19, 2023
View reviewed changes
morimoto-cybozu
morimoto-cybozu requested changes Oct 20, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
cmd/necoperf-cli/cmd/profile.go Outdated Show resolved Hide resolved
docs/necoperf-cli.md Outdated Show resolved Hide resolved
internal/client/client.go Outdated Show resolved Hide resolved
@zeroalphat @morimoto-cybozu
Remove file existence checks
b6cca12 
Co-authored-by: morimoto-cybozu <[email protected]>
morimoto-cybozu
morimoto-cybozu approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroalphat zeroalphat merged commit 546147e into main Oct 20, 2023
3 checks passed
@zeroalphat zeroalphat deleted the add-necoperf-cli branch October 20, 2023 08:39
@zeroalphat zeroalphat added the enhancement New feature or request label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morimoto-cybozu morimoto-cybozu morimoto-cybozu approved these changes

@umezawatakeshi umezawatakeshi umezawatakeshi left review comments

@zoetrope zoetrope Awaiting requested review from zoetrope

Assignees

@zeroalphat zeroalphat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeroalphat @morimoto-cybozu @umezawatakeshi