Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC protocol definition for necoperf #5

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Add gRPC protocol definition for necoperf #5

merged 2 commits into from
Sep 21, 2023

Conversation

zeroalphat
Copy link
Contributor

No description provided.

@zeroalphat zeroalphat self-assigned this Sep 15, 2023
@zeroalphat zeroalphat marked this pull request as ready for review September 19, 2023 00:07
zoetrope
zoetrope previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroalphat
Copy link
Contributor Author

zeroalphat commented Sep 19, 2023 •
edited
Loading

For implementation reasons, I changed the type of timeout to duration.
May I ask you to review it again 🙇

@zeroalphat zeroalphat merged commit a160f75 into main Sep 21, 2023
3 checks passed
@zeroalphat zeroalphat deleted the add-proto-file branch September 21, 2023 05:16
@zeroalphat zeroalphat added the enhancement New feature or request label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoetrope zoetrope zoetrope approved these changes

Assignees

@zeroalphat zeroalphat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeroalphat @zoetrope